From: Herbert Xu <herbert@gondor.apana.org.au>
To: "lianfeng.ouyang" <lianfeng.ouyang@starfivetech.com>
Cc: Olivia Mackall <olivia@selenic.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] hwrng: starfive: rework clk/reset teardown order for JHB100
Date: Fri, 4 Sep 2026 19:24:26 +1000 [thread overview]
Message-ID: <apqOSl1m-5ctry_T@gondor.apana.org.au> (raw)
In-Reply-To: <20260812023401.44149-3-lianfeng.ouyang@starfivetech.com>
On Wed, Aug 12, 2026 at 10:34:01AM +0800, lianfeng.ouyang wrote:
> From: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
>
> Rework the StarFive TRNG driver to address hardware-specific requirements
> for JHB100 SoC. To avoid reset-domain crossing glitches, the driver now
> ensures clocks are gated before asserting reset during teardown for
> JHB100, while JH7110 retains the original reset-first sequence.
>
> Add per-compatible match data (struct starfive_trng_data) describing the
> clock/reset teardown order, a new "starfive,jhb100-trng" compatible, and
> select the ordering from it.
>
> Fix the runtime-PM get/put balancing across the init/read/reseed/cleanup
> paths, manage PM and the clk/reset teardown via devm so all error paths
> unwind correctly, run the SEU-triggered reseed from a workqueue instead
> of hard IRQ, and serialise the command sequences with a mutex.
>
> Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
> ---
> MAINTAINERS | 2 +-
> drivers/char/hw_random/jh7110-trng.c | 295 +++++++++++++++++++++------
> 2 files changed, 239 insertions(+), 58 deletions(-)
Sashiko wasn't able to apply your patches. Please try rebasing
and reposting.
https://sashiko.dev/#/patchset/20260812023401.44149-1-lianfeng.ouyang%40starfivetech.com
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-09-04 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 2:33 [PATCH v7 0/2] hwrng: starfive: add JHB100 support and fix clk/reset teardown lianfeng.ouyang
2026-08-12 2:34 ` [PATCH v7 1/2] dt-bindings: rng: starfive,jh7110-trng: add jhb100, drop jh8100 lianfeng.ouyang
2026-08-12 2:34 ` [PATCH v7 2/2] hwrng: starfive: rework clk/reset teardown order for JHB100 lianfeng.ouyang
2026-09-04 9:24 ` Herbert Xu [this message]
2026-09-04 9:35 ` 回复: " Lianfeng Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apqOSl1m-5ctry_T@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox