Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Florian Westphal <fw@strlen.de>
Cc: kadlec@netfilter.org, linux-crypto@vger.kernel.org
Subject: Re: [v2 PATCH] rhashtable: Add rhashtable_flush_and_free helper
Date: Sun, 13 Sep 2026 09:27:31 +1000	[thread overview]
Message-ID: <aqXf46iXp4BhuPud@gondor.apana.org.au> (raw)
In-Reply-To: <aqWazNYddvTO5Sjn@strlen.de>

On Sat, Sep 12, 2026 at 08:32:44PM +0200, Florian Westphal wrote:
>
> When you send next version, could you elaborate a bit why this is
> required?  rht_deferred_worker grabs the ht mutex, so I don't understand
> this problem.  Worst case is a single,
> "useless" rehash of a most likely empty (or at least mostly empty) table.

You're right.  I mistakenly thought that a scheduled rehash may
cause a rehash without resizing the table, but that's not how it
works since only insertions can trigger a direct rehash, and that
doesn't even happen in the delayed worker.

Let me see if I can simplify this.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2026-09-12 23:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 10:16 [v2 PATCH] rhashtable: Add rhashtable_flush_and_free helper Herbert Xu
2026-09-12 18:32 ` Florian Westphal
2026-09-12 23:27   ` Herbert Xu [this message]
2026-09-13  0:12     ` [v3 " Herbert Xu
2026-09-13  1:34       ` [v4 " Herbert Xu
2026-09-13  2:53         ` [v5 " Herbert Xu
2026-09-13  6:31           ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqXf46iXp4BhuPud@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox