From: Herbert Xu <herbert@gondor.apana.org.au>
To: Thorsten Blum <blum@kernel.org>
Cc: Olivia Mackall <olivia@selenic.com>,
Manos Pitsidianakis <manos@pitsidianak.is>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
David Laight <david.laight.linux@gmail.com>,
Jonathan McDowell <noodles@meta.com>,
Lianjie Wang <karin0.zst@gmail.com>,
"Thomas Richard (TI)" <thomas.richard@bootlin.com>,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwrng: core - reject unknown RNG names
Date: Fri, 2 Oct 2026 20:13:25 +1000 [thread overview]
Message-ID: <ar-DxYN0dBs3FXNZ@gondor.apana.org.au> (raw)
In-Reply-To: <20260924212114.120633-2-blum@kernel.org>
On Thu, Sep 24, 2026 at 11:21:13PM +0200, Thorsten Blum wrote:
> In rng_current_store(), err is 0 after successfully locking rng_mutex,
> and if the requested RNG name cannot be found, the function reports
> success even though the current RNG was not changed.
>
> Set err = -ENODEV before searching the RNG list to reject unknown names.
>
> Fixes: 142a27f0a731 ("hwrng: core - Reset user selected rng by writing "" to rng_current")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
> drivers/char/hw_random/core.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-10-02 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 21:21 [PATCH] hwrng: core - reject unknown RNG names Thorsten Blum
2026-09-25 10:00 ` Andy Shevchenko
2026-09-25 10:06 ` Andy Shevchenko
2026-10-02 10:13 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar-DxYN0dBs3FXNZ@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andriy.shevchenko@intel.com \
--cc=blum@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=karin0.zst@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manos@pitsidianak.is \
--cc=noodles@meta.com \
--cc=olivia@selenic.com \
--cc=prasannatsmkumar@gmail.com \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox