From: Herbert Xu <herbert@gondor.apana.org.au>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Jia Jie Ho <jiajie.ho@starfivetech.com>,
Olivia Mackall <olivia@selenic.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwrng: starfive: propagate clock and reset errors
Date: Wed, 23 Sep 2026 18:47:22 +1000 [thread overview]
Message-ID: <arOSGqzzWTjH5J7S@gondor.apana.org.au> (raw)
In-Reply-To: <20260830131753.3744-1-pengpeng@iscas.ac.cn>
On Sun, Aug 30, 2026 at 09:17:53PM +0800, Pengpeng Hou wrote:
> The StarFive TRNG probe and resume paths ignore failures from their clock
> and reset operations. That lets the driver register or resume while its
> hardware access prerequisites were not established.
>
> Check each transition, unwind only the previously enabled clock on failure,
> and propagate the error to the probe or PM core.
>
> Fixes: c388f458bc34 ("hwrng: starfive - Add TRNG driver for StarFive SoC")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/char/hw_random/jh7110-trng.c | 39 +++++++++++++++++++++++++++---------
> 1 file changed, 29 insertions(+), 10 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-09-23 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 13:17 [PATCH] hwrng: starfive: propagate clock and reset errors Pengpeng Hou
2026-09-23 8:47 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arOSGqzzWTjH5J7S@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jiajie.ho@starfivetech.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=p.zabel@pengutronix.de \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox