Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
	stable@vger.kernel.org,
	Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Ahsan Atta <ahsan.atta@intel.com>
Subject: Re: [PATCH] crypto: qat - fix error source for QAT GEN6 transmit interface faults
Date: Wed, 23 Sep 2026 18:49:16 +1000	[thread overview]
Message-ID: <arOSjKbX-VIucSUI@gondor.apana.org.au> (raw)
In-Reply-To: <20260916075536.1361895-1-suman.kumar.chakraborty@intel.com>

On Wed, Sep 16, 2026 at 07:55:36AM +0000, Suman Kumar Chakraborty wrote:
> TI_CD_PAR_STS faults were being decoded under ERRSOU1, which is
> incorrect for QAT GEN6 devices. They are actually raised on ERRSOU3.
> 
> Move the handling of TI_CD_PAR_STS faults as part of the ERRSOU3 logic
> and split the status bits by their actual source:
> 
>  - Bits 0-18 (TI_INT_ERR_DEVHALT) handled when a DEVHALT is signalled
>    and are counted once as ADF_RAS_FATAL.
>  - Bit 19 (TIMISCSTS) handled separately and counted as ADF_RAS_UNCORR.
> 
> Previously, a TI_INT_ERR_DEVHALT fault also incremented ADF_RAS_UNCORR
> in addition to ADF_RAS_FATAL. Since a DEVHALT is already fatal, remove
> the redundant increment.
> 
> Bits 20-25 of TI_CD_PAR_STS are unused/reserved on QAT GEN6. Remove them
> from the mask.
> 
> Cc: stable@vger.kernel.org
> Fixes: 7f3401d0a506 ("crypto: qat - enable RAS support for GEN6 devices")
> Signed-off-by: Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Ahsan Atta <ahsan.atta@intel.com>
> ---
>  .../intel/qat/qat_common/adf_gen6_ras.c       | 20 +++++++++++++---
>  .../intel/qat/qat_common/adf_gen6_ras.h       | 24 ++++++++++---------
>  2 files changed, 30 insertions(+), 14 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      reply	other threads:[~2026-09-23  8:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:55 [PATCH] crypto: qat - fix error source for QAT GEN6 transmit interface faults Suman Kumar Chakraborty
2026-09-23  8:49 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arOSjKbX-VIucSUI@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ahsan.atta@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=suman.kumar.chakraborty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox