Re: [PATCH] crypto: qat - remove unused get_num_accels()

[Herbert Xu <herbert@gondor.apana.org.au>]

On Thu, Oct 01, 2026 at 01:28:41PM +0100, Ahsan Atta wrote:
> The get_num_accels() hook in struct adf_hw_device_data has had no
> callers since commit d237230728c5 ("crypto: qat - remove unused
> character device and IOCTLs"), which deleted its last user in
> adf_ctl_drv.c. Every device driver still populates it and two
> implementations are still exported, all of it dead code.
> 
> Remove the hook, its generation-level implementations
> adf_gen2_get_num_accels() and adf_gen4_get_num_accels(), the
> per-device static implementations and all the assignments.
> 
> The hw_data->num_accel field is left untouched as it is still used.
> 
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
>  drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c   | 1 -
>  drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c     | 1 -
>  drivers/crypto/intel/qat/qat_6xxx/adf_6xxx_hw_data.c     | 6 ------
>  drivers/crypto/intel/qat/qat_c3xxx/adf_c3xxx_hw_data.c   | 1 -
>  .../crypto/intel/qat/qat_c3xxxvf/adf_c3xxxvf_hw_data.c   | 6 ------
>  drivers/crypto/intel/qat/qat_c62x/adf_c62x_hw_data.c     | 1 -
>  drivers/crypto/intel/qat/qat_c62xvf/adf_c62xvf_hw_data.c | 6 ------
>  drivers/crypto/intel/qat/qat_common/adf_accel_devices.h  | 1 -
>  drivers/crypto/intel/qat/qat_common/adf_gen2_hw_data.c   | 9 ---------
>  drivers/crypto/intel/qat/qat_common/adf_gen2_hw_data.h   | 1 -
>  drivers/crypto/intel/qat/qat_common/adf_gen4_hw_data.c   | 6 ------
>  drivers/crypto/intel/qat/qat_common/adf_gen4_hw_data.h   | 1 -
>  .../crypto/intel/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c | 1 -
>  .../intel/qat/qat_dh895xccvf/adf_dh895xccvf_hw_data.c    | 6 ------
>  14 files changed, 47 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt