From: Sean Christopherson <seanjc@google.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Michael Roth <michael.roth@amd.com>,
linux-crypto@vger.kernel.org, davem@davemloft.net,
ackerleytng@google.com, thomas.lendacky@amd.com,
ashish.kalra@amd.com, aik@amd.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 0/9] crypto: ccp - Make sev_cmd_mutex more granular
Date: Wed, 21 Oct 2026 07:39:10 -0700 [thread overview]
Message-ID: <atjOjlPKWuSjFFXx@google.com> (raw)
In-Reply-To: <athNHhrMegveNJBU@gondor.apana.org.au>
+Paolo
On Wed, Oct 21, 2026, Herbert Xu wrote:
> On Tue, Oct 20, 2026 at 04:42:19PM -0500, Michael Roth wrote:
> >
> > Hi Herbert,
> >
> > It looks like the above-mentioned KVM patches are queued for 7.4, so these
> > CCP fixes would be needed to avoid the above-mentioned deadlock scenario
> > with KVM.
> >
> > Would it be possible to get these CCP fixups in for 7.4?
>
> Sorry, these patches are too big and too late for 7.4.
>
> If there is a specific bug that must be fixed in 7.4, please
> post a minimal fix for it without including the refactoring.
I'm with Herbert on this one, the "Use __free() handlers" refactorings in particular
strike me as unnecessary for the "fix", especially since __free() can have some
nasty gotchas with respect to ordering. It seems like it should be doable to go
with a smaller (though still non-trivial) set of changes for 7.4, and then do the
fancy cleanups on top for 7.5.
If making sev_cmd_mutex usage more granular is itself too much for 7.4, the
the alternative is to disable/disallow SNP if guest_memfd in-place conversion is
enabled. I personally don't care terribly if SNP and in-place conversion are
mutually exclusive for one kernel release, but I also don't have a vested interest
in any particular upstream kernel. Well, unless 7.4 ends up being the next LTS
(but I don't think it will be?), in which case I would push very hard for landing
the mutex changes.
next prev parent reply other threads:[~2026-10-21 14:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 4:09 [PATCH v2 0/9] crypto: ccp - Make sev_cmd_mutex more granular Michael Roth
2026-10-16 4:09 ` [PATCH v2 1/9] crypto: ccp - Shut down SEV firmware before copying to user Michael Roth
2026-10-16 4:09 ` [PATCH v2 2/9] crypto: ccp - Check SNP initialization state after copying user inputs Michael Roth
2026-10-16 4:09 ` [PATCH v2 3/9] crypto: ccp - Use __free() handlers for sev_ioctl_do_pek_csr() allocations Michael Roth
2026-10-19 13:33 ` Tom Lendacky
2026-10-16 4:09 ` [PATCH v2 4/9] crypto: ccp - Use __free() handlers for sev_ioctl_do_pek_import() allocations Michael Roth
2026-10-19 13:38 ` Tom Lendacky
2026-10-16 4:09 ` [PATCH v2 5/9] crypto: ccp - Use __free() handlers for sev_ioctl_do_pdh_export() allocations Michael Roth
2026-10-19 13:40 ` Tom Lendacky
2026-10-16 4:09 ` [PATCH v2 6/9] crypto: ccp: - Rework sev_ioctl_do_pdh_export() to avoid goto usage Michael Roth
2026-10-19 13:49 ` Tom Lendacky
2026-10-16 4:09 ` [PATCH v2 7/9] crypto: ccp - Make usage of sev_cmd_mutex more granular Michael Roth
2026-10-16 4:09 ` [PATCH v2 8/9] crypto: ccp - Use __free() handlers for __sev_do_snp_platform_status() allocations Michael Roth
2026-10-19 14:03 ` Tom Lendacky
2026-10-16 4:09 ` [PATCH v2 9/9] crypto: ccp - Allocate status page outside sev_cmd_mutex in SNP_PLATFORM_STATUS Michael Roth
2026-10-19 14:05 ` Tom Lendacky
2026-10-20 21:42 ` [PATCH v2 0/9] crypto: ccp - Make sev_cmd_mutex more granular Michael Roth
2026-10-21 5:26 ` Herbert Xu
2026-10-21 14:39 ` Sean Christopherson [this message]
2026-10-21 15:00 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atjOjlPKWuSjFFXx@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=ashish.kalra@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox