From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.8 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793701708; b=Ie8qn1OrNtToaIN3jt2hRbbrzY74Ra99/ED/yuquEAae/wg0qgiW4heJY4LwEjn5DL7s adcdfV8i6ofdfTeBtjP0Uy2Hn3cC9KoMX5Gq6zoTqTvvQ2hVQSjgKfaTBFrM2B8qjMF+o dOocs0+LqNdYsYmIflOGFWSJVwrLRM742oc3/jsP1M6zGPygFIcSrqqWiquj7DkQ2utQo 5hp54dPcK5ucDgfvu6/kxogG6M4FsSXx/pVpHiOdTz7Fhu8AIswS5ErhK30vf5+5/dtmh 255Bw/uysoBglw8+ozc+GSq4xSpBoYyVTY1V5eNZrbyn9DNnb3lp/o9muZNUZiPiGLA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793701708; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=brI27/R3evN0ktEK8A0I0W9UNIMPS/xp4y6+g+aCaBo=; b=hwgRZn0MjZPjWZib1pXmbbR6wNYwBny8wtL/BHgHyhiQbIJ1pgMpDxZVQiKdGKKgNb6u 9vGeQhXNqBG4c6MdJI4W/k7IpXU5wW6An9OY9ZlmP2/0okJtqgs1LJCL3CWUMenk919gC x5ngl0JJE57VNQVRCUFLGEIv2lBzIzsyJqSbf26miBC/VuvY33x0j0bHlcYOmS4H/vmGM sMsBC6W9A2OWXka2rGfse55oDJwTZlo5z06Rl9p792AOJ0u9MZHar6IpZUkAJJ1G3A8+j LAPmB+azru28Sl4dbZSCq+m+5YrIrnzeXkhnszHQsyzWOPhxSV6tic42sjg51f9tTWA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=I+7E1g4J; arc=none smtp.remote-ip=192.198.163.8 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6EC4606FAF5; Tue, 3 Nov 2026 10:28:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B6EC4606FAF5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=I+7E1g4J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793701707; x=1825237707; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/azmaKzOQApHWRANZvyKMDE5eR/p+FiNIyfzDv8GWBc=; b=I+7E1g4JHJecLkpIciu5oeD36dnuzruzJCqWeQVAwUzwY0RTZB6go0fJ ewYkGD2V03kW5UvP57iXn6MyQ9GKKrt0O7tteHHRgOdW+R5hoOnLaUh/M AWb1o1Mg5tKQh2BlQ9GVZFTgzCADCzV+kg5fV201ZKYQfeZU5nAjDCWhK 85nEEUON+8s7lWbW2+/WxQoeovXatOckRV/UT3r5I/3pDcQE06qmxyqhe /41C9gXhqWXZMfyvkWOzh5uQcXy1R8E9q6VktKDjTtCQrX2gtzOYZeJ88 1NFCm9Q7NNQuxWyYjjVSzwS09qPBO6BDtHp//gHhixfNy/ukFQ7atP/PL w==; X-CSE-ConnectionGUID: KD/mWuJATtGw+9yWx+CIFQ== X-CSE-MsgGUID: bcIageVgQu67I/XKkuriJQ== X-IronPort-AV: E=McAfee;i="6800,10657,11954"; a="2310418" X-IronPort-AV: E=Sophos;i="6.27,193,1787036400"; d="scan'208";a="2310418" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2026 02:28:26 -0800 X-CSE-ConnectionGUID: 1bIC71+GRU+9xXUc9Jx1pA== X-CSE-MsgGUID: V2qjLPU4SH2zD8mLISaVAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,193,1787036400"; d="scan'208";a="6387021" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.108]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2026 02:28:22 -0800 Date: Tue, 3 Nov 2026 12:28:20 +0200 From: Andy Shevchenko To: Pawel Zalewski Cc: Lee Jones , Chen-Yu Tsai , David Rhodes , Richard Fitzgerald , Mika Westerberg , Zha Qipeng , Qunqin Zhao , Thomas Richard , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-crypto@vger.kernel.org Subject: Re: [PATCH] mfd: Use named initializers for acpi_device_id Message-ID: References: <20261102-acpi-mfd-v1-1-d61029971be8@thegoodpenguin.co.uk> X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261102-acpi-mfd-v1-1-d61029971be8@thegoodpenguin.co.uk> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Nov 02, 2026 at 12:25:14PM +0000, Pawel Zalewski wrote: > Use a designated initializer for the acpi_device_id fields which makes the > code more readable and consistent with how lists are initialized in the > rest of the kernel code base. Also drop explicitly setting fields to 0 > where it is redundant. > > Unify the list terminator to have a single space between the brackets and > no trailing comma. Can you split Intel LPSS to a separate patch? It will help reviewing both parts. -- With Best Regards, Andy Shevchenko