From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.manguebit.org (mx1.manguebit.org [143.255.12.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDBF94DA535; Tue, 3 Mar 2026 16:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=143.255.12.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772554990; cv=none; b=SeDVd1c0TmhfoLBdVz7c3j9Hqs3XHdmI2LuhfXJySR+ggiMnpiMuU9zRC4yxK4/U19UsHPXuff+7ra7n3bPd9veArEZfP0sBe0pXSRTMzV4uyp3YY2JVF8qtiT7CKJf2xfiSR+N9SDnV7fClqAdWIfaC5kwS6aN9uZkVupUF3es= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772554990; c=relaxed/simple; bh=c387aLCQdXYFSYbwsR4Veo4DFnlWEejCosFk7YnqKM4=; h=Message-ID:From:To:Cc:Subject:In-Reply-To:References:Date: MIME-Version:Content-Type; b=jSj3Se1xkJenlbQPXfqLwVeAbAFIY1q5bxHIgruGCCN+zvPaSatNeZZdDRi7ExUrfrHlyTZJQKucziXaB/hIlyBLGla8i+fVd3fdnz5LRulah+7wjMuIZl2tILAOPPjP9TMkFIR+LK39fWmzEH6XVUP3Nlp9NuHKxo5UH4+rMPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manguebit.org; spf=pass smtp.mailfrom=manguebit.org; dkim=pass (2048-bit key) header.d=manguebit.org header.i=@manguebit.org header.b=EP9cpmpX; arc=none smtp.client-ip=143.255.12.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manguebit.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manguebit.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manguebit.org header.i=@manguebit.org header.b="EP9cpmpX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=manguebit.org; s=dkim; h=Content-Type:MIME-Version:Date:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3XU0kehnvWrcKYHKgel0/xHOmH34b+yFHPZHUnnR7DU=; b=EP9cpmpXUdqoEKJjhaJAscQj+q ERr2YdHhoZa3uZ+fkZ4HC5sqjhusS1J05lLX1QVygyQk9gXco7ygJmsDcPOfLklWdUR9OIW5MU6r3 GxIw66iS1OFhLrsJN0V3CpeKsQhPn0T8aroY8jr6LzMvP3ZZs/XDldL4FKAY62KZGPLV0Ojomd2d6 pyvMg3SrOUe8gfsOjAOKkmuI8SZ5tIun0XDD/lkU6RBaTYwaVoMyVUhKwzAvPkWjTpxTCKGzq9EQ4 twg25N4c/0RthJ/McjBur6DWeGMLKBBzs5ZDg9IrFiytBdvfpVWQ46r7Xan+Nc/b2GuIoGacQ8OM+ sVgb0O6Q==; Received: from pc by mx1.manguebit.org with local (Exim 4.99.1) id 1vxSWS-00000000Ae6-2bOc; Tue, 03 Mar 2026 13:23:00 -0300 Message-ID: From: Paulo Alcantara To: Eric Biggers , Steve French , linux-cifs@vger.kernel.org Cc: samba-technical@lists.samba.org, linux-crypto@vger.kernel.org, Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Eric Biggers , stable@vger.kernel.org Subject: Re: [PATCH] smb: client: Compare MACs in constant time In-Reply-To: <20260218042702.67907-1-ebiggers@kernel.org> References: <20260218042702.67907-1-ebiggers@kernel.org> Date: Tue, 03 Mar 2026 13:23:00 -0300 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Eric Biggers writes: > To prevent timing attacks, MAC comparisons need to be constant-time. > Replace the memcmp() with the correct function, crypto_memneq(). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Signed-off-by: Eric Biggers > --- > fs/smb/client/smb1encrypt.c | 3 ++- > fs/smb/client/smb2transport.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) Acked-by: Paulo Alcantara (Red Hat)