Re: [PATCH -next] hwrng: atmel - use clk_disable_unprepare instead of clk_disable

[Nicolas Ferre <nicolas.ferre@atmel.com>]

Le 11/11/2016 à 15:56, Wei Yongjun a écrit :
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Since clk_prepare_enable() is used to get trng->clk, we should
> use clk_disable_unprepare() to release it for the error path.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thank you.

Best regards,

> ---
>  drivers/char/hw_random/atmel-rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
> index ae7cae5..661c82c 100644
> --- a/drivers/char/hw_random/atmel-rng.c
> +++ b/drivers/char/hw_random/atmel-rng.c
> @@ -94,7 +94,7 @@ static int atmel_trng_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_register:
> -	clk_disable(trng->clk);
> +	clk_disable_unprepare(trng->clk);
>  	return ret;
>  }
> 
> 


-- 
Nicolas Ferre