From: Tom Lendacky <thomas.lendacky@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Ashish Kalra <ashish.kalra@amd.com>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp - don't abuse kernel-doc comment format
Date: Thu, 30 Jul 2026 10:50:25 -0500 [thread overview]
Message-ID: <b93d7af8-7214-4baf-a386-f730bc67fcf5@amd.com> (raw)
In-Reply-To: <20260730051710.1412969-1-rdunlap@infradead.org>
On 7/30/26 00:17, Randy Dunlap wrote:
> Use plain C "/*" notation for comments that are not in kernel-doc format
> to avoid kernel-doc warnings:
>
> Warning: include/uapi/linux/psp-sfs.h:18 expecting prototype for SFS().
> Prototype was for PAYLOAD_NAME_SIZE() instead
> Warning: include/uapi/linux/psp-sfs.h:46 This comment starts with '/**',
> but isn't a kernel-doc comment.
> * Seamless Firmware Support (SFS) IOC
>
> Fixes: 648dbccc03a0 ("crypto: ccp - Add AMD Seamless Firmware Servicing (SFS) driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> Cc: Ashish Kalra <ashish.kalra@amd.com>
> Cc: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
>
> include/uapi/linux/psp-sfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20260729.orig/include/uapi/linux/psp-sfs.h
> +++ linux-next-20260729/include/uapi/linux/psp-sfs.h
> @@ -12,7 +12,7 @@
>
> #include <linux/types.h>
>
> -/**
> +/*
> * SFS: AMD Seamless Firmware Support (SFS) interface
> */
>
> @@ -43,7 +43,7 @@ struct sfs_user_update_package {
> __u32 sfs_extended_status;
> } __packed;
>
> -/**
> +/*
> * Seamless Firmware Support (SFS) IOC
> *
> * possible return codes for all SFS IOCTLs:
prev parent reply other threads:[~2026-07-30 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:17 [PATCH] crypto: ccp - don't abuse kernel-doc comment format Randy Dunlap
2026-07-30 15:50 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93d7af8-7214-4baf-a386-f730bc67fcf5@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox