Re: [PATCH v3 2/6] Add SPAcc Skcipher support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/06/2025 14:02, Pavitrakumar Managutte wrote:

>> Please run standard kernel tools for static analysis, like coccinelle,
>> smatch and sparse, and fix reported warnings. Also please check for
>> warnings when building with W=1 for gcc and clang. Most of these
>> commands (checks or W=1 build) can build specific targets, like some
>> directory, to narrow the scope to only your code. The code here looks
>> like it needs a fix. Feel free to get in touch if the warning is not clear.
>>
Confirm that you understood this. You sent us code with obvious flaws
which would be found with tools. It's a proof you did not run these
static tools. It's not the job of community reviewers to replace the
tools. Using us instead of tools is... well, a mistake but if you think
about our limited time then kind of close to inappropriate request. So
did you understand the need of using tools BEFORE you post it?

Best regards,
Krzysztof