From: "Horia Geantă" <horia.geanta@nxp.com>
To: Iuliana Prodan <iuliana.prodan@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Aymen Sghaier <aymen.sghaier@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Silvano Di Ninno <silvano.dininno@nxp.com>,
Franck Lenormand <franck.lenormand@nxp.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Andrei Botila <andrei.botila@nxp.com>,
Dragos Rosioru <dragos.rosioru@nxp.com>
Subject: Re: [PATCH] crypto: caam - enable crypto-engine retry mechanism
Date: Mon, 26 Oct 2020 19:57:59 +0200 [thread overview]
Message-ID: <bae6b3d7-582a-c9fc-c118-992d780ef5ed@nxp.com> (raw)
In-Reply-To: <ebdad102-fe91-7324-8096-dc1dc2313786@nxp.com>
On 10/26/2020 7:11 PM, Iuliana Prodan wrote:
> On 10/26/2020 5:36 PM, Horia Geantă wrote:
>> On 10/21/2020 11:07 PM, Iuliana Prodan wrote:
[...]
>>> +#define CRYPTO_ENGINE_MAX_QLEN (2 * (JOBR_DEPTH - THRESHOLD))
>>> +
>> What's the logic behind multiplying by 2?
>
> I added the 2 as the number of Job Rings.
> My logic was that crypto-engine is one per CAAM (x no of JRs), while
> JOB_DEPTH is per JR.
Currently there is one crypto-engine per JR.
crypto_engine_alloc_init() is called when caam/jr driver is probing.
> I know there are targets with other than 2 JRs. Therefore, is there a
> way to get this number automatically?
>
Most SoCs have CAAM configured with 4 JRs.
Of course what's visible to the kernel might be different.
Given there's one crypto-engine / JR, determining the number of JRs
shouldn't be required.
Horia
prev parent reply other threads:[~2020-10-26 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 20:06 [PATCH] crypto: caam - enable crypto-engine retry mechanism Iuliana Prodan
2020-10-26 15:36 ` Horia Geantă
2020-10-26 17:11 ` Iuliana Prodan
2020-10-26 17:57 ` Horia Geantă [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bae6b3d7-582a-c9fc-c118-992d780ef5ed@nxp.com \
--to=horia.geanta@nxp.com \
--cc=andrei.botila@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=dragos.rosioru@nxp.com \
--cc=franck.lenormand@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=silvano.dininno@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox