From: Stefan Berger <stefanb@linux.ibm.com>
To: Fabian Blatter <fabianblatter09@gmail.com>,
lukas@wunner.de, ignat@linux.win, herbert@gondor.apana.org.au,
davem@davemloft.net
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ecc - Optimize vli additive operations using compiler builtins
Date: Tue, 9 Jun 2026 14:58:09 -0400 [thread overview]
Message-ID: <bd992448-8ded-46f8-bf91-97792b9a11ad@linux.ibm.com> (raw)
In-Reply-To: <20260607112435.42804-1-fabianblatter09@gmail.com>
On 6/7/26 7:24 AM, Fabian Blatter wrote:
> Replace the software carry flag emulation with compiler builtins.
>
> Even the newest compilers struggle with taking advantage of the
> hardware carry flag. Compiler builtins allow the compiler to
> much more easily achieve this while still remaining constant-time.
It looks like you made vli_usub and vli_uadd constant-time now because
otherwise the loops could be ended early once borrow == 0 or carry == 0
respectively. Are all the other functions that operate on the private
keys constant-time?
next prev parent reply other threads:[~2026-06-09 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 11:24 [PATCH] crypto: ecc - Optimize vli additive operations using compiler builtins Fabian Blatter
2026-06-09 18:58 ` Stefan Berger [this message]
2026-06-09 20:51 ` Fabian
2026-06-10 14:52 ` Stefan Berger
2026-06-10 16:57 ` Fabian
2026-06-10 17:25 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd992448-8ded-46f8-bf91-97792b9a11ad@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=fabianblatter09@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@linux.win \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox