From: Jon Hunter <jonathanh@nvidia.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-crypto@vger.kernel.org>, <arnd@arndb.de>
Cc: herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] crypto: arm - add build time test for CRC instruction support
Date: Tue, 28 Feb 2017 15:54:13 +0000 [thread overview]
Message-ID: <be137899-cd94-5fb3-1f14-c1921509e0d7@nvidia.com> (raw)
In-Reply-To: <1488292617-27317-2-git-send-email-ard.biesheuvel@linaro.org>
On 28/02/17 14:36, Ard Biesheuvel wrote:
> The accelerated CRC32 module for ARM may use either the scalar CRC32
> instructions, the NEON 64x64 to 128 bit polynomial multiplication
> (vmull.p64) instruction, or both, depending on what the current CPU
> supports.
>
> However, this also requires support in binutils, and as it turns out,
> versions of binutils exist that support the vmull.p64 instruction but
> not the crc32 instructions.
>
> So refactor the Makefile logic so that this module only gets built if
> binutils has support for both.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2017-02-28 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 14:36 [PATCH 1/2] crypto: arm/crc32 - fix build error with outdated binutils Ard Biesheuvel
2017-02-28 14:36 ` [PATCH 2/2] crypto: arm - add build time test for CRC instruction support Ard Biesheuvel
2017-02-28 15:54 ` Jon Hunter [this message]
2017-03-01 11:52 ` Herbert Xu
2017-03-01 11:52 ` [PATCH 1/2] crypto: arm/crc32 - fix build error with outdated binutils Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be137899-cd94-5fb3-1f14-c1921509e0d7@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox