Re: [PATCH v14 03/19] x86: Secure Launch Resource Table header file

ross.philipson
2025-04-24T19:20:43Z

On 4/24/25 5:36 AM, Huang, Kai wrote:
>
>> +
>> +#ifndef __ASSEMBLY__
>>
> [...]
>
>> +#endif /* !__ASSEMBLY */
>>
>
> A minor thing:
>
> There's an attempt to convert __ASSEMBLY__ to __ASSEMBLER__ at tree-wide level:
>
> https://urldefense.com/v3/__https://lore.kernel.org/lkml/20250314071013.1575167-1-thuth@redhat.com/__;!!ACWV5N9M2RV99hQ!MhSEDY0kYk37uZxtStR43EmL_ySswhslosStYlSCe97P72GzkHTmhJQsz9okEBy6HDQOCAWJkyV7mvRkYcA89g$
>
> I am not sure the final result (there's some discussion around uapi part, but it
> seems there's no objection to changes to the headers visible only to the
> kernel), but the x86 ones have been merged:
>
> x86/headers: Replace __ASSEMBLY__ with __ASSEMBLER__ in non-UAPI headers
> x86/headers: Replace __ASSEMBLY__ with __ASSEMBLER__ in UAPI headers
>
> So perhaps we should use __ASSEMBLER__ for the new code.

Yes good call. I see a number of those patches to switch to
__ASSEMBLER__ are already in.

Thanks
Ross