Re: [PATCH v14 02/19] x86: Secure Launch Kconfig

ross.philipson
2025-04-22T19:33:04Z

On 4/21/25 10:41 AM, Randy Dunlap wrote:
> Hi,
>
> On 4/21/25 9:26 AM, Ross Philipson wrote:
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 4b9f378e05f6..badde1e9742e 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -2001,6 +2001,17 @@ config EFI_RUNTIME_MAP
>>
>> See also Documentation/ABI/testing/sysfs-firmware-efi-runtime-map.
>>
>> +config SECURE_LAUNCH
>> + bool "Secure Launch support"
>> + depends on X86_64 && X86_X2APIC && TCG_TIS && TCG_CRB && CRYPTO_LIB_SHA1 && CRYPTO_LIB_SHA256
>
> It's normal to select needed library symbols instead of depending on them.
> Nothing else in the kernel tree uses depends on for these 2 Kconfig symbols.
> (CRYPTO_LIB_SHAxxx)

Yes good point, we will address this.

Ross

>
>> + help
>> + The Secure Launch feature allows a kernel to be loaded
>> + directly through an Intel TXT measured launch. Intel TXT
>> + establishes a Dynamic Root of Trust for Measurement (DRTM)
>> + where the CPU measures the kernel image. This feature then
>> + continues the measurement chain over kernel configuration
>> + information and init images.
>