Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "Alessandrelli, Daniele" <daniele.alessandrelli@intel.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>
Cc: "Murphy, Declan" <declan.murphy@intel.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] crypto: keembay-ocs-hcu - Fix a WARN() message
Date: Wed, 6 Jan 2021 12:10:11 +0000	[thread overview]
Message-ID: <c9fb1462004f6cdca99538889faa3f96436fca1c.camel@intel.com> (raw)
In-Reply-To: <X/WB9IlpyIi+5p5s@mwanda>

Hi Dan,

Thanks for finding and fixing this.

On Wed, 2021-01-06 at 12:25 +0300, Dan Carpenter wrote:
> The first argument to WARN() is a condition and the messages is the
> second argument is the string, so this WARN() will only display the
> __func__ part of the message.
> 
> Fixes: ae832e329a8d ("crypto: keembay-ocs-hcu - Add HMAC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/crypto/keembay/keembay-ocs-hcu-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 

Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>

  reply	other threads:[~2021-01-06 12:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06  9:25 [PATCH] crypto: keembay-ocs-hcu - Fix a WARN() message Dan Carpenter
2021-01-06 12:10 ` Alessandrelli, Daniele [this message]
2021-01-14  6:47 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9fb1462004f6cdca99538889faa3f96436fca1c.camel@intel.com \
    --to=daniele.alessandrelli@intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=declan.murphy@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox