From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Zizhuang Deng <sunsetdzz@gmail.com>, herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] lib/mpi: Add the return value check of kcalloc()
Date: Thu, 30 Dec 2021 15:26:30 +0800 [thread overview]
Message-ID: <ca006060-10d8-bdd4-0824-943750542f61@linux.alibaba.com> (raw)
In-Reply-To: <20211230070331.1046343-1-sunsetdzz@gmail.com>
On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---
Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Best regards,
Tianjia
> lib/mpi/mpi-mod.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>
> mpi_normalize(m);
> ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return NULL;
>
> if (copy) {
> ctx->m = mpi_copy(m);
next prev parent reply other threads:[~2021-12-30 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 7:03 [PATCH] lib/mpi: Add the return value check of kcalloc() Zizhuang Deng
2021-12-30 7:26 ` Tianjia Zhang [this message]
2022-01-07 3:33 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca006060-10d8-bdd4-0824-943750542f61@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunsetdzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox