Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Mathias Krause <mathias.krause@secunet.com>
To: linux-crypto@vger.kernel.org
Cc: Mathias Krause <mathias.krause@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Christian Hohnstaedt <chohnstaedt@innominate.com>,
	Kim Phillips <kim.phillips@freescale.com>,
	Jamie Iles <jamie@jamieiles.com>
Subject: [PATCH 0/5] Authenc key parsing consolidation
Date: Tue, 15 Oct 2013 13:49:29 +0200	[thread overview]
Message-ID: <cover.1381831574.git.mathias.krause@secunet.com> (raw)

This series removes the code duplication of authenc key parsing by
introducing a common helper function crypto_authenc_extractkeys() in
patch 1. Patches 2 to 5 change all remaining places to use the new
helper. Patches 3 and 4 also fix potential memory corruptions by
ensuring the supplied keys won't overflow there respective buffers.

I was unable to test patches 3 to 5 as I don't have the needed hardware
for these devices -- not even a cross compiler for those architectures.

In case patches 3 and 4 are enqueued for stable, patch 1 needs to be as
well, as it's a prerequisite for those.

Please apply!

Mathias Krause (5):
  crypto: authenc - Export key parsing helper function
  crypto: authencesn - Simplify key parsing
  crypto: ixp4xx - Simplify and harden key parsing
  crypto: picoxcell - Simplify and harden key parsing
  crypto: talitos - Simplify key parsing

 crypto/authenc.c                  |   48 +++++++++++++++++++++++--------------
 crypto/authencesn.c               |   26 +++-----------------
 drivers/crypto/ixp4xx_crypto.c    |   26 +++++++-------------
 drivers/crypto/picoxcell_crypto.c |   32 ++++++------------------
 drivers/crypto/talitos.c          |   35 ++++++--------------------
 include/crypto/authenc.h          |   12 ++++++++-
 6 files changed, 70 insertions(+), 109 deletions(-)

-- 
1.7.2.5

             reply	other threads:[~2013-10-15 11:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 11:49 Mathias Krause [this message]
2013-10-15 11:49 ` [PATCH 1/5] crypto: authenc - Export key parsing helper function Mathias Krause
2013-10-15 11:49 ` [PATCH 2/5] crypto: authencesn - Simplify key parsing Mathias Krause
2013-10-15 11:49 ` [PATCH 3/5] crypto: ixp4xx - Simplify and harden " Mathias Krause
2013-10-15 11:49 ` [PATCH 4/5] crypto: picoxcell " Mathias Krause
2013-10-15 11:49 ` [PATCH 5/5] crypto: talitos - Simplify " Mathias Krause
2013-10-16 12:58 ` [PATCH 0/5] Authenc key parsing consolidation Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1381831574.git.mathias.krause@secunet.com \
    --to=mathias.krause@secunet.com \
    --cc=chohnstaedt@innominate.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jamie@jamieiles.com \
    --cc=kim.phillips@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox