From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Tim Chen <tim.c.chen@linux.intel.com>,
Mathias Krause <minipli@googlemail.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
Peter Zijlstra <peterz@infradead.org>,
linux-crypto@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
Andy Lutomirski <luto@kernel.org>, Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH v2 00/12] x86/crypto: Fix RBP usage in several crypto .S files
Date: Mon, 18 Sep 2017 14:41:59 -0500 [thread overview]
Message-ID: <cover.1505763153.git.jpoimboe@redhat.com> (raw)
v2:
- fix performance issues in sha256-avx2-asm.S and sha512-avx2-asm.S
(Eric)
Many of the x86 crypto functions use RBP as a temporary register. This
breaks frame pointer convention, and breaks stack traces when unwinding
from an interrupt in the crypto code.
Convert most* of them to leave RBP alone.
These pass the crypto boot tests for me. Any further testing would be
appreciated!
[*] There are still a few crypto files left that need fixing, but the
fixes weren't trivial and nobody reported unwinder warnings about
them yet, so I'm skipping them for now.
Josh Poimboeuf (12):
x86/crypto: Fix RBP usage in blowfish-x86_64-asm_64.S
x86/crypto: Fix RBP usage in camellia-x86_64-asm_64.S
x86/crypto: Fix RBP usage in cast5-avx-x86_64-asm_64.S
x86/crypto: Fix RBP usage in cast6-avx-x86_64-asm_64.S
x86/crypto: Fix RBP usage in des3_ede-asm_64.S
x86/crypto: Fix RBP usage in sha1_avx2_x86_64_asm.S
x86/crypto: Fix RBP usage in sha1_ssse3_asm.S
x86/crypto: Fix RBP usage in sha256-avx-asm.S
x86/crypto: Fix RBP usage in sha256-avx2-asm.S
x86/crypto: Fix RBP usage in sha256-ssse3-asm.S
x86/crypto: Fix RBP usage in sha512-avx2-asm.S
x86/crypto: Fix RBP usage in twofish-avx-x86_64-asm_64.S
arch/x86/crypto/blowfish-x86_64-asm_64.S | 48 +++++++++---------
arch/x86/crypto/camellia-x86_64-asm_64.S | 26 +++++-----
arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 47 +++++++++++-------
arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 50 +++++++++++++------
arch/x86/crypto/des3_ede-asm_64.S | 15 +++---
arch/x86/crypto/sha1_avx2_x86_64_asm.S | 4 +-
arch/x86/crypto/sha1_ssse3_asm.S | 11 ++---
arch/x86/crypto/sha256-avx-asm.S | 15 +++---
arch/x86/crypto/sha256-avx2-asm.S | 22 +++------
arch/x86/crypto/sha256-ssse3-asm.S | 15 +++---
arch/x86/crypto/sha512-avx2-asm.S | 75 +++++++++++++++--------------
arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 12 ++---
12 files changed, 184 insertions(+), 156 deletions(-)
--
2.13.5
next reply other threads:[~2017-09-18 19:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 19:41 Josh Poimboeuf [this message]
2017-09-18 19:42 ` [PATCH v2 01/12] x86/crypto: Fix RBP usage in blowfish-x86_64-asm_64.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 02/12] x86/crypto: Fix RBP usage in camellia-x86_64-asm_64.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 03/12] x86/crypto: Fix RBP usage in cast5-avx-x86_64-asm_64.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 04/12] x86/crypto: Fix RBP usage in cast6-avx-x86_64-asm_64.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 05/12] x86/crypto: Fix RBP usage in des3_ede-asm_64.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 06/12] x86/crypto: Fix RBP usage in sha1_avx2_x86_64_asm.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 07/12] x86/crypto: Fix RBP usage in sha1_ssse3_asm.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 08/12] x86/crypto: Fix RBP usage in sha256-avx-asm.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 09/12] x86/crypto: Fix RBP usage in sha256-avx2-asm.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 10/12] x86/crypto: Fix RBP usage in sha256-ssse3-asm.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 11/12] x86/crypto: Fix RBP usage in sha512-avx2-asm.S Josh Poimboeuf
2017-09-18 19:42 ` [PATCH v2 12/12] x86/crypto: Fix RBP usage in twofish-avx-x86_64-asm_64.S Josh Poimboeuf
2017-09-21 8:05 ` [PATCH v2 00/12] x86/crypto: Fix RBP usage in several crypto .S files Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1505763153.git.jpoimboe@redhat.com \
--to=jpoimboe@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=jslaby@suse.cz \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=minipli@googlemail.com \
--cc=peterz@infradead.org \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).