From: David Sterba <dsterba@suse.com>
To: linux-crypto@vger.kernel.org
Cc: ard.biesheuvel@linaro.org, ebiggers@google.com,
David Sterba <dsterba@suse.com>
Subject: [PATCH v4 0/5] BLAKE2b generic implementation
Date: Fri, 11 Oct 2019 18:52:03 +0200 [thread overview]
Message-ID: <cover.1570812094.git.dsterba@suse.com> (raw)
The patchset adds blake2b refrerence implementation and test vectors.
V4:
Code changes:
- removed .finup
- removed .cra_init
- dropped redundant sanity checks (key length, output size length)
- switch blake2b_param from a 1 element array to plain struct
- direct assignment in blake2b_init, instead of put_unaligned*
- removed blake2b_is_lastblock
- removed useless error cases in the blake * helpers
- replace digest_desc_ctx with blake2b_state
- use __le32 in blake2b_param
Added testmgr vectors:
- all digests covered: 160, 256, 384, 512
- 4 different keys:
- empty
- short (1 byte, 'B', 0x42)
- half of the default key (32 bytes, sequence 00..1f)
- default key (64 bytes, sequence 00..3f)
- plaintext values:
- subsequences of 0..15 and 247..255
- the full range 0..255 add up to 4MiB of .h, for all digests and key
sizes, so this is not very practical for the in-kernel testsuite
- official blake2 provided test vectors are only for empty and default key for
digest size 512
- the remaining combinations were obtained from b2sum utility (enhanced to
accept a key)
Testing performed:
- compiled with SLUB_DEBUG and KASAN, plus crypto selftests
CONFIG_CRYPTO_MANAGER2=y
CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
- module loaded, no errors reported from the tessuite
- (un)intentionally broken test values were detected
The test values were produced by b2sum, compiled from the reference
implementation. The generated values were cross-checked by pyblake2
based script (ie. not the same sources, built by distro).
The .h portion of testmgr is completely generated, so in case somebody feels
like reducing it in size, adding more keys, changing the formatting, it's easy
to do.
In case the patches don't make it to the mailinglist, it's in git
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git dev/blake2b-v4
V1: https://lore.kernel.org/linux-crypto/cover.1569849051.git.dsterba@suse.com/
V2: https://lore.kernel.org/linux-crypto/e31c2030fcfa7f409b2c81adf8f179a8a55a584a.1570184333.git.dsterba@suse.com/
V3: https://lore.kernel.org/linux-crypto/e7f46def436c2c705c0b2cac3324f817efa4717d.1570715842.git.dsterba@suse.com/
David Sterba (5):
crypto: add blake2b generic implementation
crypto: add test vectors for blake2b-160
crypto: add test vectors for blake2b-256
crypto: add test vectors for blake2b-384
crypto: add test vectors for blake2b-512
crypto/Kconfig | 17 +
crypto/Makefile | 1 +
crypto/blake2b_generic.c | 418 ++
crypto/testmgr.c | 28 +
crypto/testmgr.h | 10561 +++++++++++++++++++++++++++++++++++++
include/crypto/blake2b.h | 48 +
6 files changed, 11073 insertions(+)
create mode 100644 crypto/blake2b_generic.c
create mode 100644 include/crypto/blake2b.h
--
2.23.0
next reply other threads:[~2019-10-11 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:52 David Sterba [this message]
2019-10-11 16:52 ` [PATCH v4 1/5] crypto: add blake2b generic implementation David Sterba
2019-10-11 18:04 ` Eric Biggers
2019-10-13 17:44 ` David Sterba
2019-10-11 18:11 ` Eric Biggers
2019-10-11 16:52 ` [PATCH v4 2/5] crypto: add test vectors for blake2b-160 David Sterba
2019-10-11 16:52 ` [PATCH v4 3/5] crypto: add test vectors for blake2b-256 David Sterba
2019-10-11 16:52 ` [PATCH v4 4/5] crypto: add test vectors for blake2b-384 David Sterba
2019-10-11 16:52 ` [PATCH v4 5/5] crypto: add test vectors for blake2b-512 David Sterba
2019-10-11 17:15 ` [PATCH v4 0/5] BLAKE2b generic implementation David Sterba
2019-10-11 17:57 ` Eric Biggers
2019-10-13 19:50 ` David Sterba
2019-10-14 2:54 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1570812094.git.dsterba@suse.com \
--to=dsterba@suse.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ebiggers@google.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).