linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Harliman Liem <pliem@maxlinear.com>
To: <atenart@kernel.org>, <herbert@gondor.apana.org.au>
Cc: <linux-crypto@vger.kernel.org>, <linux-lgm-soc@maxlinear.com>,
	<pvanleeuwen@rambus.com>,
	Peter Harliman Liem <pliem@maxlinear.com>
Subject: [PATCH v2 0/3] crypto: inside-secure: Add Support for MaxLinear Platform
Date: Tue, 27 Sep 2022 11:10:07 +0800	[thread overview]
Message-ID: <cover.1664247167.git.pliem@maxlinear.com> (raw)

Hi,

I have been utilizing inside-secure driver on MaxLinear
SoC platform (which has eip197 hardware inside).

One issue I found is that I needed to flip the endianness
in eip197_write_firmware() function, which for reason I am
not aware is using big-endian.
The firmware that I have is clearly using little-endian,
and unfortunately I do not have access to Marvell platform
to do more investigation or comparison there.
I have also tried to look for clues in Inside-Secure's
hardware/firmware documentation, without success.

Thus, assuming each vendor may use different endian format,
on these patch set I add support for little-endian firmware
(default remains big-endian). MaxLinear platform can then
utilize the option, which is implemented as soc data.

An alternative to this would be implementing the option
as a new device-tree property, but for now I assume we do
not need that since each platform endianness should be
fixed, and will not vary per board/hardware.

Please help review.

Thanks!

v2:
 Revert directory change for generic case.
 Add missing driver data change in pci_device_id.
 Rename data struct to safexcel_priv_data.
 Rework endianness selection code casting, to fix warning caught by kernel test robot.
 Rename mxl version string to eip197 'c'.

Peter Harliman Liem (3):
  crypto: inside-secure - Expand soc data structure
  crypto: inside-secure - Add fw_little_endian option
  crypto: inside-secure - Add MaxLinear platform

 drivers/crypto/inside-secure/safexcel.c | 69 ++++++++++++++++++-------
 drivers/crypto/inside-secure/safexcel.h | 10 +++-
 2 files changed, 59 insertions(+), 20 deletions(-)

-- 
2.17.1


             reply	other threads:[~2022-09-27  3:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27  3:10 Peter Harliman Liem [this message]
2022-09-27  3:10 ` [PATCH v2 1/3] crypto: inside-secure - Expand soc data structure Peter Harliman Liem
2022-09-27  3:10 ` [PATCH v2 2/3] crypto: inside-secure - Add fw_little_endian option Peter Harliman Liem
2022-09-27  3:10 ` [PATCH v2 3/3] crypto: inside-secure - Add MaxLinear platform Peter Harliman Liem
2022-10-21 11:33 ` [PATCH v2 0/3] crypto: inside-secure: Add Support for MaxLinear Platform Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1664247167.git.pliem@maxlinear.com \
    --to=pliem@maxlinear.com \
    --cc=atenart@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-lgm-soc@maxlinear.com \
    --cc=pvanleeuwen@rambus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).