From: "Pratik R. Sampat" <prsampat@amd.com>
To: Tycho Andersen <tycho@kernel.org>
Cc: ashish.kalra@amd.com, thomas.lendacky@amd.com,
john.allen@amd.com, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, aik@amd.com, nikunj@amd.com,
michael.roth@amd.com
Subject: Re: [PATCH v4] crypto/ccp: Introduce SNP_VERIFY_MITIGATION command
Date: Thu, 11 Jun 2026 09:44:30 -0400 [thread overview]
Message-ID: <d0f6d93a-6c07-4b33-bc89-a498d7d2c34f@amd.com> (raw)
In-Reply-To: <aihsp-uQrd2g5vJ0@tycho.pizza>
On 6/9/26 3:48 PM, Tycho Andersen wrote:
> Hi Pratik,
>
>>
>> See SEV-SNP Firmware ABI specifications 1.58, SNP_VERIFY_MITIGATION for
>> more details.
>>
>> Signed-off-by: Pratik R. Sampat <prsampat@amd.com>
>
> Reviewed-by: Tycho Andersen (AMD) <tycho@kernel.org>
>
>> + if (dst.mit_failure_status) {
>> + dev_err(sev->dev, "Verify Mitigation - failure status: 0x%x\n",
>> + dst.mit_failure_status);
>> + return -EIO;
>
> Elsewhere the CCP uses EIO to represent a failure to communicate with
> the PSP, but here things worked, it was just in an invalid state.
> Maybe worth a different errno here, -EINVAL or so.
>
-EIO is a bit awkward here for sure. -EINVAL seems to make more sense.
Thanks!
--Pratik
prev parent reply other threads:[~2026-06-11 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 20:58 [PATCH v4] crypto/ccp: Introduce SNP_VERIFY_MITIGATION command Pratik R. Sampat
2026-06-09 16:06 ` Tom Lendacky
2026-06-09 16:19 ` Pratik R. Sampat
2026-06-09 19:48 ` Tycho Andersen
2026-06-11 13:44 ` Pratik R. Sampat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f6d93a-6c07-4b33-bc89-a498d7d2c34f@amd.com \
--to=prsampat@amd.com \
--cc=aik@amd.com \
--cc=ashish.kalra@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=tycho@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox