Re: [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'?

[Jia Jie Ho <jiajie.ho@starfivetech.com>]

On 19/5/2023 7:33 pm, kernel test robot wrote:
> Hi Jia,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   7883d1b28a2b0e62edcacea22de6b36a1918b15a
> commit: 42ef0e944b0119e9987819af0a5a04d32d5e5edf [21/22] crypto: starfive - Add crypto engine support
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230519/202305191929.Eq4OVZ6D-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=42ef0e944b0119e9987819af0a5a04d32d5e5edf
>         git remote add herbert-cryptodev-2.6 https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
>         git fetch --no-tags herbert-cryptodev-2.6 master
>         git checkout 42ef0e944b0119e9987819af0a5a04d32d5e5edf
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/tty/serial/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202305191929.Eq4OVZ6D-lkp@intel.com/
> 
> All error/warnings (new ones prefixed by >>):
> 
>    drivers/tty/serial/amba-pl011.c: In function 'pl011_sgbuf_init':
>>> drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? [-Werror=implicit-function-declaration]
>      379 |         sg_set_page(&sg->sg, phys_to_page(dma_addr),
>          |                              ^~~~~~~~~~~~
>          |                              pfn_to_page
>>> drivers/tty/serial/amba-pl011.c:379:30: warning: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion]
>      379 |         sg_set_page(&sg->sg, phys_to_page(dma_addr),
>          |                              ^~~~~~~~~~~~~~~~~~~~~~
>          |                              |
>          |                              int
>    In file included from include/linux/kfifo.h:42,
>                     from include/linux/tty_port.h:5,
>                     from include/linux/tty.h:12,
>                     from drivers/tty/serial/amba-pl011.c:25:
>    include/linux/scatterlist.h:136:69: note: expected 'struct page *' but argument is of type 'int'
>      136 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
>          |                                                        ~~~~~~~~~~~~~^~~~
>    cc1: some warnings being treated as errors
> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for DMADEVICES
>    Depends on [n]: HAS_DMA [=n]
>    Selected by [m]:
>    - CRYPTO_DEV_JH7110 [=m] && CRYPTO [=y] && CRYPTO_HW [=y] && (SOC_STARFIVE || COMPILE_TEST [=y])
> 

Hi Herbert,

Should I submit a new patch to select HAS_DMA in my Kconfig?

Thanks,
Jia Jie