From: Alexander Graf <graf@amazon.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Olivia Mackall" <olivia@selenic.com>,
Petre Eftime <petre.eftime@gmail.com>,
"Erdem Meydanlli" <meydanli@amazon.nl>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Woodhouse <dwmw@amazon.co.uk>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH 1/2] misc: Add Nitro Secure Module driver
Date: Fri, 29 Sep 2023 12:45:37 +0200 [thread overview]
Message-ID: <d6e4fba3-ecaf-4cf3-8447-0f9a8f8bbaeb@amazon.com> (raw)
In-Reply-To: <2023092918-sulfide-stonework-f6b7@gregkh>
On 29.09.23 07:45, Greg Kroah-Hartman wrote:
>
> On Thu, Sep 28, 2023 at 10:46:44PM +0000, Alexander Graf wrote:
>> +/* Register this as a misc driver */
>> +#define NSM_DEV_NAME "nsm"
>> +#define NSM_IOCTL_MAGIC 0x0A
>> +#define NSM_IO_REQUEST _IOWR(NSM_IOCTL_MAGIC, 0, struct nsm_message)
> You have an ioctl for this driver, yet no include/uapi/ file for it?
> How is userspace supposed to know about this and use it?
D'oh. Will fix :). Thanks!
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2023-09-29 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 22:46 [PATCH 0/2] Add Nitro Secure Module support Alexander Graf
2023-09-28 22:46 ` [PATCH 1/2] misc: Add Nitro Secure Module driver Alexander Graf
2023-09-29 5:44 ` Greg Kroah-Hartman
2023-09-29 10:44 ` Alexander Graf
2023-09-29 5:45 ` Greg Kroah-Hartman
2023-09-29 10:45 ` Alexander Graf [this message]
2023-09-28 22:46 ` [PATCH 2/2] hwrng: Add support for Nitro Secure Module Alexander Graf
2023-09-29 3:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e4fba3-ecaf-4cf3-8447-0f9a8f8bbaeb@amazon.com \
--to=graf@amazon.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meydanli@amazon.nl \
--cc=mst@redhat.com \
--cc=olivia@selenic.com \
--cc=petre.eftime@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox