From: Tom Lendacky <thomas.lendacky@amd.com>
To: Peter Gonda <pgonda@google.com>
Cc: David Rientjes <rientjes@google.com>,
Marc Orr <marcorr@google.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Joerg Roedel <jroedel@suse.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
John Allen <john.allen@amd.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 4/4] crypto: ccp - Add SEV_INIT_EX support
Date: Mon, 1 Nov 2021 15:02:22 -0500 [thread overview]
Message-ID: <d6fc38fa-1caa-289a-ae92-102a96638560@amd.com> (raw)
In-Reply-To: <CAMkAt6qdNWP-Ka1N=0d16Q1TrbHPXPEkdLoxC8ndsyid-dqA6Q@mail.gmail.com>
On 11/1/21 2:18 PM, Peter Gonda wrote:
> On Mon, Nov 1, 2021 at 12:41 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>> On 11/1/21 12:21 PM, Peter Gonda wrote:
...
>>> +
>>> + fp = filp_open(init_ex_path, O_RDONLY, 0);
>>> + if (IS_ERR(fp)) {
>>> + const int ret = PTR_ERR(fp);
>>
>> I don't think you need the "const" here.
>
> Sounds good, removed. I normally default to consting a variable if I
> don't expect/want it to change. What guidance should I be following
> here?
Heh, I don't know... I guess since its in such a short scope it just read
easier to me. But, you're correct, const is appropriate here, so I guess
feel free to leave it in if you want.
>
>>
...
>> "SEV: write successful to NV file\n"
>
> Updated all messages. Should have noted the "SEV: .." format.
It's not like we were very consistent originally, but it would be nice to
have the new messages start to maintain a consistency.
Thanks,
Tom
>
next prev parent reply other threads:[~2021-11-01 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:21 [PATCH V2 0/4] Add SEV_INIT_EX support Peter Gonda
2021-11-01 17:21 ` [PATCH V2 1/4] crypto: ccp - Fix SEV_INIT error logging on init Peter Gonda
2021-11-01 17:21 ` [PATCH V2 2/4] crypto: ccp - Move SEV_INIT retry for corrupted data Peter Gonda
2021-11-01 17:21 ` [PATCH V2 3/4] crypto: ccp - Refactor out sev_fw_alloc() Peter Gonda
2021-11-01 17:21 ` [PATCH V2 4/4] crypto: ccp - Add SEV_INIT_EX support Peter Gonda
2021-11-01 18:41 ` Tom Lendacky
2021-11-01 19:18 ` Peter Gonda
2021-11-01 20:02 ` Tom Lendacky [this message]
2021-11-02 14:21 ` Peter Gonda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6fc38fa-1caa-289a-ae92-102a96638560@amd.com \
--to=thomas.lendacky@amd.com \
--cc=brijesh.singh@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=jroedel@suse.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox