From: Taehee Yoo <ap420073@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
kirill.shutemov@linux.intel.com, richard@nod.at,
viro@zeniv.linux.org.uk,
sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi,
ebiggers@kernel.org
Subject: Re: [PATCH v6 2/4] crypto: aria: do not use magic number offsets of aria_ctx
Date: Sat, 3 Dec 2022 14:01:54 +0900 [thread overview]
Message-ID: <e0c38961-44cc-943b-8739-420867fdc5ce@gmail.com> (raw)
In-Reply-To: <Y4nPbMHNQl++bItU@gondor.apana.org.au>
Hi Herbert,
Thank you so much for your review!
On 12/2/22 19:11, Herbert Xu wrote:
> On Mon, Nov 21, 2022 at 12:39:53AM +0000, Taehee Yoo wrote:
>>
>> +#if defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64) || \
>> + defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64_MODULE)
>
> Why isn't this IS_ENABLED like the hunk below?
>
>> +
>> + /* Offset for fields in aria_ctx */
>> + BLANK();
>> + OFFSET(ARIA_CTX_enc_key, aria_ctx, enc_key);
>> + OFFSET(ARIA_CTX_dec_key, aria_ctx, dec_key);
>> + OFFSET(ARIA_CTX_rounds, aria_ctx, rounds);
>> +#endif
>> +
>> if (IS_ENABLED(CONFIG_KVM_INTEL)) {
>> BLANK();
>> OFFSET(VMX_spec_ctrl, vcpu_vmx, spec_ctrl);
>
> Thanks,
I missed cleaning it up.
I will use IS_ENABLED() instead of defined() in the v7.
Thanks a lot!
Taehee Yoo
next prev parent reply other threads:[~2022-12-03 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 0:39 [PATCH v6 0/4] crypto: aria: implement aria-avx2 and aria-avx512 Taehee Yoo
2022-11-21 0:39 ` [PATCH v6 1/4] crypto: aria: add keystream array into request ctx Taehee Yoo
2022-11-21 0:39 ` [PATCH v6 2/4] crypto: aria: do not use magic number offsets of aria_ctx Taehee Yoo
2022-12-02 10:11 ` Herbert Xu
2022-12-03 5:01 ` Taehee Yoo [this message]
2022-11-21 0:39 ` [PATCH v6 3/4] crypto: aria: implement aria-avx2 Taehee Yoo
2022-11-21 0:39 ` [PATCH v6 4/4] crypto: aria: implement aria-avx512 Taehee Yoo
2022-11-21 9:47 ` [PATCH v6 0/4] crypto: aria: implement aria-avx2 and aria-avx512 Borislav Petkov
2022-11-21 11:20 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0c38961-44cc-943b-8739-420867fdc5ce@gmail.com \
--to=ap420073@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=elliott@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=jussi.kivilinna@iki.fi \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox