Re: [PATCH 17/19] selftests: Add -t tcp_authopt option for fcnal-test.sh

David Ahern
2021-09-25T01:52:55Z

On 9/21/21 10:15 AM, Leonard Crestez wrote:
> This script is otherwise very slow to run!

there are a lot of permutations to cover.

>
> Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
> index 74a7580b6bde..484734db708f 100755
> --- a/tools/testing/selftests/net/fcnal-test.sh
> +++ b/tools/testing/selftests/net/fcnal-test.sh
> @@ -1331,10 +1331,21 @@ ipv4_tcp()
> log_subsection "With VRF"
> setup "yes"
> ipv4_tcp_vrf
> }
>
> +
> +only_tcp_authopt()
> +{
> + log_section "TCP Authentication"
> + setup
> + set_sysctl net.ipv4.tcp_l3mdev_accept=0
> + log_subsection "IPv4 no VRF"
> + ipv4_tcp_authopt

This feature needs to work with VRF from the beginning. v4, v6, with and
without VRF.

> +}
> +
> +
> ################################################################################
> # IPv4 UDP
>
> ipv4_udp_novrf()
> {
> @@ -4021,10 +4032,11 @@ do
> ipv6_bind|bind6) ipv6_addr_bind;;
> ipv6_runtime) ipv6_runtime;;
> ipv6_netfilter) ipv6_netfilter;;
>
> use_cases) use_cases;;
> + tcp_authopt) only_tcp_authopt;;
>
> # setup namespaces and config, but do not run any tests
> setup) setup; exit 0;;
> vrf_setup) setup "yes"; exit 0;;
>
>

This patch can be folded into the previous one, and the drop the
only_tcp_authopt function. The script has always allowed a single test
to be run by name (-t arg), so '-t tcp_authopt' runs tcp_authopt which
covers v4 and v6 with and without vrf.