From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gary R Hook Subject: Re: [PATCH 1/2] crypto: ccp - Reduce stack frame size with KASAN Date: Tue, 28 Mar 2017 10:56:55 -0500 Message-ID: References: <20170328095814.3734615-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "Lendacky, Thomas" , Herbert Xu , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Arnd Bergmann , "Hook, Gary" Return-path: Received: from mail-cys01nam02on0085.outbound.protection.outlook.com ([104.47.37.85]:56093 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752228AbdC1P5L (ORCPT ); Tue, 28 Mar 2017 11:57:11 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On 03/28/2017 10:10 AM, Arnd Bergmann wrote: >>> -}; >>> +} __packed __aligned(4); >> >> My gcc 4.8 doesn't understand __aligned(). Shouldn't we use >> #pragma(4) here? > > That is odd, the __aligned() macro gets defined for all compiler versions > in linux/compiler.h, and the aligned attribute should work for all supported > compilers (3.2 and higher), while #pragma pack() requires gcc-4.0 or > higher. > Tried again in a couple of trees. Not sure what I did wrong, but the compiler seems to be happy now. Huh. Will submit a V2. -- This is my day job. Follow me at: IG/Twitter/Facebook: @grhookphoto IG/Twitter/Facebook: @grhphotographer