From: LeoLiu-oc <leoliu-oc@zhaoxin.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: <olivia@selenic.com>, <herbert@gondor.apana.org.au>,
<jiajie.ho@starfivetech.com>, <conor.dooley@microchip.com>,
<martin@kaiser.cx>, <mmyangfl@gmail.com>,
<jenny.zhang@starfivetech.com>, <linux-kernel@vger.kernel.org>,
<linux-crypto@vger.kernel.org>, <leoliu@zhaoxin.com>,
<CobeChen@zhaoxin.com>, <YunShen@zhaoxin.com>,
<TonyWWang@zhaoxin.com>
Subject: Re: [PATCH] hwrng: add Zhaoxin HW RNG driver
Date: Mon, 31 Jul 2023 11:19:35 +0800 [thread overview]
Message-ID: <e8140373-9249-e2cb-9767-8459f90245ee@zhaoxin.com> (raw)
In-Reply-To: <ZMITRjPOQAZ8qaZL@Red>
在 2023/7/27 14:48, Corentin Labbe 写道:
> Le Wed, Jul 26, 2023 at 07:35:53PM +0800, LeoLiu-oc a écrit :
>> From: leoliu-oc <leoliu-oc@zhaoxin.com>
>>
>> Add support for Zhaoxin HW RNG.
>>
>> Signed-off-by: leoliu-oc <leoliu-oc@zhaoxin.com>
>> ---
>> drivers/char/hw_random/Kconfig | 13 +++
>> drivers/char/hw_random/Makefile | 1 +
>> drivers/char/hw_random/via-rng.c | 17 ++--
>
> Hello
>
> You are doing changes in via-rng without stating why.
> If changes are needed in via-rng, you should do this in a separate patch.
>
> Regards
OK，Got it.Thanks for your advice,I will modify it in the next version.
Leoliu-oc
prev parent reply other threads:[~2023-07-31 3:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:35 [PATCH] hwrng: add Zhaoxin HW RNG driver LeoLiu-oc
2023-07-26 12:13 ` Martin Kaiser
2023-07-31 3:04 ` LeoLiu-oc
2023-07-26 23:26 ` kernel test robot
2023-07-27 2:24 ` kernel test robot
2023-07-27 6:48 ` Corentin Labbe
2023-07-31 3:19 ` LeoLiu-oc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8140373-9249-e2cb-9767-8459f90245ee@zhaoxin.com \
--to=leoliu-oc@zhaoxin.com \
--cc=CobeChen@zhaoxin.com \
--cc=TonyWWang@zhaoxin.com \
--cc=YunShen@zhaoxin.com \
--cc=clabbe.montjoie@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=herbert@gondor.apana.org.au \
--cc=jenny.zhang@starfivetech.com \
--cc=jiajie.ho@starfivetech.com \
--cc=leoliu@zhaoxin.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=mmyangfl@gmail.com \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox