From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Vadim Fedorenko <vadfed@meta.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Mykola Lysenko <mykolal@fb.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Network Development <netdev@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo selftests
Date: Sun, 19 Nov 2023 23:52:51 +0000 [thread overview]
Message-ID: <ee9e6afb-479e-d38f-9424-5c79feded44d@linux.dev> (raw)
In-Reply-To: <CAADnVQ+tLbMppLNT7HOV5=k+8075qjjyO5wWEDvLRoPi5WALJw@mail.gmail.com>
On 19.11.2023 21:58, Alexei Starovoitov wrote:
> On Sat, Nov 18, 2023 at 2:55 PM Vadim Fedorenko <vadfed@meta.com> wrote:
>>
>> +
>> +SEC("fentry.s/bpf_fentry_test1")
>> +int BPF_PROG(skb_crypto_setup)
>> +{
>> + struct bpf_crypto_lskcipher_ctx *cctx;
>> + struct bpf_dynptr key = {};
>> + int err = 0;
>> +
>> + status = 0;
>> +
>> + bpf_dynptr_from_mem(crypto_key, sizeof(crypto_key), 0, &key);
>> + cctx = bpf_crypto_lskcipher_ctx_create(crypto_algo, &key, &err);
>
> Direct string will work here, right?
> What's the reason to use global var?
Mmm, yeah, should work. I'll update the test, thanks!
next prev parent reply other threads:[~2023-11-19 23:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 22:54 [PATCH bpf-next v5 1/2] bpf: add skcipher API support to TC/XDP programs Vadim Fedorenko
2023-11-18 22:54 ` [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo selftests Vadim Fedorenko
2023-11-19 21:58 ` Alexei Starovoitov
2023-11-19 23:52 ` Vadim Fedorenko [this message]
2023-11-18 23:23 ` [PATCH bpf-next v5 1/2] bpf: add skcipher API support to TC/XDP programs Alexei Starovoitov
2023-11-18 23:32 ` Vadim Fedorenko
2023-11-18 23:35 ` Alexei Starovoitov
2023-11-18 23:46 ` Vadim Fedorenko
2023-11-19 16:56 ` Alexei Starovoitov
2023-11-20 0:22 ` Vadim Fedorenko
2023-11-20 1:13 ` Alexei Starovoitov
2023-11-20 18:08 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9e6afb-479e-d38f-9424-5c79feded44d@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=vadfed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).