From: Eduard Zingerman <eddyz87@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-crypto@vger.kernel.org,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Use sha1() instead of sha1_transform() in bpf_prog_calc_tag()
Date: Mon, 11 Aug 2025 15:16:15 -0700 [thread overview]
Message-ID: <efc1618c4d24e6c80aa51f61981bf6a24912cd97.camel@gmail.com> (raw)
In-Reply-To: <20250811201615.564461-1-ebiggers@kernel.org>
On Mon, 2025-08-11 at 13:16 -0700, Eric Biggers wrote:
> Now that there's a proper SHA-1 library API, just use that instead of
> the low-level SHA-1 compression function. This eliminates the need for
> bpf_prog_calc_tag() to implement the SHA-1 padding itself. No
> functional change; the computed tags remain the same.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
The logic seem to unchanged.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
next prev parent reply other threads:[~2025-08-11 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 20:16 [PATCH bpf-next] bpf: Use sha1() instead of sha1_transform() in bpf_prog_calc_tag() Eric Biggers
2025-08-11 22:16 ` Eduard Zingerman [this message]
2025-08-12 0:57 ` Song Liu
2025-08-12 4:15 ` Eric Biggers
2025-08-22 18:40 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efc1618c4d24e6c80aa51f61981bf6a24912cd97.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ebiggers@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).