From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
James Bottomley <jejb@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2 1/2] crypto: use SM3 instead of SM3_256
Date: Sat, 23 Oct 2021 03:48:17 +0300 [thread overview]
Message-ID: <f5c87a233027c8026ae8574f3e25c9162da3bfff.camel@kernel.org> (raw)
In-Reply-To: <20211019100423.43615-2-tianjia.zhang@linux.alibaba.com>
On Tue, 2021-10-19 at 18:04 +0800, Tianjia Zhang wrote:
> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
> SM3 always produces a 256-bit hash value and there are no plans for
> other length development, so there is no ambiguity in the name of sm3.
>
> Suggested-by: James Bottomley <jejb@linux.ibm.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> Documentation/security/keys/trusted-encrypted.rst | 2 +-
> crypto/hash_info.c | 4 ++--
> drivers/char/tpm/tpm2-cmd.c | 2 +-
> include/crypto/hash_info.h | 2 +-
> include/uapi/linux/hash_info.h | 3 ++-
> security/keys/trusted-keys/trusted_tpm2.c | 2 +-
> 6 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst
> index 80d5a5af62a1..3292461517f6 100644
> --- a/Documentation/security/keys/trusted-encrypted.rst
> +++ b/Documentation/security/keys/trusted-encrypted.rst
> @@ -162,7 +162,7 @@ Usage::
> default 1 (resealing allowed)
> hash= hash algorithm name as a string. For TPM 1.x the only
> allowed value is sha1. For TPM 2.x the allowed values
> - are sha1, sha256, sha384, sha512 and sm3-256.
> + are sha1, sha256, sha384, sha512 and sm3.
You cannot remove sm3-256 from uapi.
/Jarkko
next prev parent reply other threads:[~2021-10-23 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 10:04 [PATCH v2 0/2] use SM3 instead of SM3_256 Tianjia Zhang
2021-10-19 10:04 ` [PATCH v2 1/2] crypto: " Tianjia Zhang
2021-10-23 0:48 ` Jarkko Sakkinen [this message]
2021-10-25 3:04 ` Tianjia Zhang
2021-10-19 10:04 ` [PATCH v2 2/2] tpm: " Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c87a233027c8026ae8574f3e25c9162da3bfff.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox