From: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-crypto@vger.kernel.org,
"Horia Geantă" <horia.geanta@nxp.com>,
"Pankaj Gupta" <pankaj.gupta@nxp.com>,
"Gaurav Jain" <gaurav.jain@nxp.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"open list" <linux-kernel@vger.kernel.org>,
"Francesco Dolcini" <francesco@dolcini.it>,
"Emanuele Ghidoli" <emanuele.ghidoli@toradex.com>
Subject: Re: [PATCH] crypto: caam: map job ring registers without claiming region
Date: Wed, 2 Sep 2026 09:55:15 +0200 [thread overview]
Message-ID: <fe9a266d-695a-4379-9aaf-8ed9ce02efa2@gmail.com> (raw)
In-Reply-To: <20260902061059.GA7187@francesco-nb>
On 9/2/26 08:10, Francesco Dolcini wrote:
> + Emanuele
>
> On Tue, Sep 01, 2026 at 01:37:36PM -0700, Rosen Penev wrote:
>> devm_platform_ioremap_resource() ends up calling request_mem_region(),
>> which fails with -EBUSY on i.MX SoCs:
>>
>> There the job rings are modelled as sub-regions of their parent
>> fsl,sec-v4.0 register window, and caam_probe() already reserves the
>> whole window exclusively via devm_of_iomap() before the children are
>> populated. Every job ring therefore collides with its own parent and
>> fails to probe, taking the hardware RNG offline (seen on i.MX6, i.MX7
>> and i.MX8 boards such as colibri-imx7 and verdin-imx8mp).
>>
>> Map the job ring registers with devm_ioremap() instead, which does not
>> claim the (already owned) region.
>>
>> Fixes: 9a955c0a7d11 ("crypto: caam - simplify probe resource and IRQ handling")
>> Assisted-by: opencode:big-pickle
>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> Reported-by: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
> Closes: https://lore.kernel.org/lkml/20260901194524.908240-1-ghidoliemanuele@gmail.com/
>
> Thanks,
> Francesco
Tested on colibri-imx7.
Tested-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Thanks,
Emanuele
prev parent reply other threads:[~2026-09-02 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 20:37 [PATCH] crypto: caam: map job ring registers without claiming region Rosen Penev
2026-09-02 6:10 ` Francesco Dolcini
2026-09-02 7:55 ` Emanuele Ghidoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe9a266d-695a-4379-9aaf-8ed9ce02efa2@gmail.com \
--to=ghidoliemanuele@gmail.com \
--cc=davem@davemloft.net \
--cc=emanuele.ghidoli@toradex.com \
--cc=francesco@dolcini.it \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox