From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDBC943D501; Mon, 31 Aug 2026 16:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788192619; cv=pass; b=DxxFsIBubCxr8Tds34i6U/QHqD6ITULKCHyklCC3r17PT+mO8x1k0mJriTTTf1nILW+zpOqBItewo/vB8mDC/B0FUjJvCL16KBir6fAco6QDPISBPyrH4acYuDh+uwDtj42LgUCM0g6DwFeBN2A5tN7787pXAjFMnHOlV5ZDTkc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788192619; c=relaxed/simple; bh=X5wkCbZNkYhkiMXotmim71xqELrwtE7oDyPKriEfYBg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sxHUR+EF93sfJlYVgrR6OznY+p6on3M9xFtCJLxwsTwL8yphiAc7hbSAFSy3azJzdPm9s3jqm4a5APqpH/iG17YuS9GANE0bWze+xmY8hJHMWLQyVQaEJW2aAHGxSKVogxr9nmPD2OX1kcMyBixC1/p+PUE8GSRBhULzFF6SRl8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=ZLyI6Orl; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="ZLyI6Orl" ARC-Seal: i=1; a=rsa-sha256; t=1788192569; cv=none; d=zohomail.com; s=zohoarc; b=UB61ER+pWQTpRPNGrqj376Ipp16JzNa7Yl5QbjOrU5joWPdBenc6M8jUOljzwSAM7hdsTLrEp71CqWwI2HJDmbpsivHjZGXFr5fHQ1y4d6rpY/CuViXTmv4k2rDKjCggkKEV3ROaoTmKPdxtExMPwdDqeMDY3XiY5VBuOtOF030= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788192569; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=oon13sUUJaLBBHt33XiRqpwiqGJmBJ1ZlxXybmNciIU=; b=noQLbt0Zut2INYexDZl9j4ktLKWnABF0jGm3qs8LYBCi+LWvykYGGnPZuuu/umxaKDNN0bVqvdkpdvThLC6Ml2vTuDCwBaZRTEXGzNPQZDxaasHpmUCnWDedOqhw5wjNwZ3Voj1ETZUG2v6E8za+WbYVRYz3KsuiJUj2CqnI8zo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788192569; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=oon13sUUJaLBBHt33XiRqpwiqGJmBJ1ZlxXybmNciIU=; b=ZLyI6OrlH4B+wHOArIu9Tgw0HLyK6f7PMAvZY8M5qgcOJ74x0Z6Qsogu3ZlAh9NQ WPA0BC+S/BpLuxmC91dI9ShcSXCTI5KAdcIuEi3QpOGl0zuxA5qS2JyVKJ/awGvRZk4 s6lmxPel6nbUKlsBfSi0YSahKYCCresQEdaz6HIM= Received: by mx.zohomail.com with SMTPS id 1788192566656889.3740455905123; Mon, 31 Aug 2026 09:09:26 -0700 (PDT) From: Nicolas Frattaroli To: Daniel Golle , Pengpeng Hou Cc: Pengpeng Hou , Aurelien Jarno , Olivia Mackall , Herbert Xu , Heiko Stuebner , Philipp Zabel , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: rockchip: propagate reset errors Date: Mon, 31 Aug 2026 18:09:22 +0200 Message-ID: In-Reply-To: <20260830133652.7618-1-pengpeng@iscas.ac.cn> References: <20260830133652.7618-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Sunday, 30 August 2026 15:36:52 Central European Summer Time Pengpeng Hou wrote: > rk_rng_probe() pulses the optional or required reset array before > registering > the hardware RNG, but discards errors from both reset operations. > > Return reset failures before publishing the RNG device. > > Fixes: 8eff8eb83fc0 ("hwrng: rockchip - add support for rk3588's standalone TRNG") > Signed-off-by: Pengpeng Hou > --- > drivers/char/hw_random/rockchip-rng.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/hw_random/rockchip-rng.c b/drivers/char/hw_random/rockchip-rng.c > index 6e3ed4b856051..ff98fcdc68911 100644 > --- a/drivers/char/hw_random/rockchip-rng.c > +++ b/drivers/char/hw_random/rockchip-rng.c > @@ -412,9 +412,14 @@ static int rk_rng_probe(struct platform_device *pdev) > if (IS_ERR(rst)) > return dev_err_probe(dev, PTR_ERR(rst), "Failed to get reset property\n"); > > - reset_control_assert(rst); > + ret = reset_control_assert(rst); > + if (ret) > + return ret; > + > udelay(2); > - reset_control_deassert(rst); > + ret = reset_control_deassert(rst); > + if (ret) > + return ret; > } > > platform_set_drvdata(pdev, rk_rng); > > base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72 > The reset controller on rockchip SoCs does not return anything other than 0 on the assert/deassert ops, and even if it did, the probe function should use dev_err_probe to report those failures. In other words, this patch only adds (non-ideal) dead code. Kind regards, Nicolas Frattaroli