From: Krzysztof Halasa <khc@pm.waw.pl>
To: linux-crypto@vger.kernel.org
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Crypto test results unused?
Date: Mon, 28 Dec 2009 20:44:20 +0100 [thread overview]
Message-ID: <m3eimerii3.fsf@intrepid.localdomain> (raw)
In-Reply-To: <m3ws07q865.fsf@intrepid.localdomain> (Krzysztof Halasa's message of "Mon, 28 Dec 2009 19:12:50 +0100")
> int crypto_register_alg(struct crypto_alg *alg)
> {
> struct crypto_larval *larval;
> int err;
>
> err = crypto_check_alg(alg);
> if (err)
> return err;
>
> down_write(&crypto_alg_sem);
> larval = __crypto_register_alg(alg);
> up_write(&crypto_alg_sem);
>
> if (IS_ERR(larval))
> return PTR_ERR(larval);
>
> crypto_wait_for_test(larval);
>
> At this point alg->cra_flags includes CRYPTO_ALG_DEAD (due to failed
> test), but larval->alg.cra_flags has only the original flags (0x85).
Actually it seems all alg->cra_flags are CRYPTO_ALG_DEAD at this point,
not only these which failed tests. Will look at it soon.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-12-28 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 18:12 Crypto test results unused? Krzysztof Halasa
2009-12-28 19:44 ` Krzysztof Halasa [this message]
2009-12-28 20:14 ` Krzysztof Halasa
2010-01-12 11:14 ` Herbert Xu
2010-01-12 17:55 ` Krzysztof Halasa
2010-01-12 22:44 ` Herbert Xu
2010-01-13 15:07 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eimerii3.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox