Re: [PATCH v2 07/30] crypto: sa2ul - remove unused includes and defines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] crypto: sa2ul - commit message omits struct field removals and leaves dead declarations
--

commit ffe272048a90096ed2fcdf326cdc814515cd3d94
Author: Manorit Chawdhry <m-chawdhry@ti.com>

crypto: sa2ul - remove unused includes and defines

This commit removes an unused header include, unused macro definitions,
and unused structure fields in the SA2UL crypto driver.

>     crypto: sa2ul - remove unused includes and defines
>     
>     Remove unused includes and define statements that are not
>     referenced anywhere in the driver.
>     
>     Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> 
> diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
> index 98075f9ffeb2a..e1e537de2d16b 100644
> --- a/drivers/crypto/sa2ul.c
> +++ b/drivers/crypto/sa2ul.c

[ ... ]

> @@ -207,14 +196,12 @@ struct sa_rx_data {
>   * @mdata_size: metadata size passed to DMA
>   */
>  struct sa_req {
> -	struct device *dev;
>  	u16 size;
>  	u8 enc_offset;
>  	u16 enc_size;
>  	u8 *enc_iv;
>  	u8 auth_offset;
>  	u16 auth_size;
> -	u8 *auth_iv;
>  	u32 type;
>  	u32 *cmdl;
>  	struct crypto_async_request *base;
> diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h
> index 6d5a3e65dae78..eedfad49793b2 100644
> --- a/drivers/crypto/sa2ul.h
> +++ b/drivers/crypto/sa2ul.h

[ ... ]

> @@ -201,7 +200,6 @@ struct sa_crypto_data {
>  	u16		sc_id;
>  	unsigned long	ctx_bm[DIV_ROUND_UP(SA_MAX_NUM_CTX,
>  				BITS_PER_LONG)];
> -	struct sa_tfm_ctx	*ctx;
>  	struct dma_chan		*dma_rx1;
>  	struct dma_chan		*dma_rx2;
>  	struct dma_chan		*dma_tx;
> @@ -210,19 +208,16 @@ struct sa_crypto_data {
>  /**
>   * struct sa_cmdl_param_info: Command label parameters info
>   * @index: Index of the parameter in the command label format
> - * @offset: the offset of the parameter
>   * @size: Size of the parameter
>   */
>  struct sa_cmdl_param_info {
>  	u16	index;
> -	u16	offset;
>  	u16	size;
>  };
>  
>  /**
>   * struct sa_cmdl_upd_info: Command label updation info
>   * @flags: flags in command label
> - * @submode: Encryption submodes
>   * @enc_size: Size of first pass encryption size
>   * @enc_offset: Encryption payload offset in the packet
>   * @enc_iv: Encryption initialization vector for pass2
> @@ -231,7 +226,6 @@ struct sa_cmdl_param_info {
>   */
>  struct sa_cmdl_upd_info {
>  	u16	flags;
> -	u16	submode;
>  	struct sa_cmdl_param_info	enc_size;
>  	struct sa_cmdl_param_info	enc_offset;
>  	struct sa_cmdl_param_info	enc_iv;
> @@ -294,13 +288,9 @@ struct sa_tfm_ctx {
>  
>  /**
>   * struct sa_sha_req_ctx: Structure used for sha request
> - * @dev_data: struct sa_crypto_data pointer
> - * @cmdl: Complete command label with psdata and epib included
>   * @fallback_req: SW fallback request container
>   */
>  struct sa_sha_req_ctx {
> -	struct sa_crypto_data	*dev_data;
> -	u32			cmdl[SA_MAX_CMDL_WORDS + SA_PSDATA_CTX_WORDS];
>  	struct ahash_request	fallback_req;
>  };

[Severity: Low]
This isn't a bug, but the commit title and message only mention removing
unused includes and define statements, whereas all of the changes in
drivers/crypto/sa2ul.h and part of drivers/crypto/sa2ul.c remove unused
structure members from struct sa_req, struct sa_crypto_data,
struct sa_cmdl_param_info, struct sa_cmdl_upd_info, and
struct sa_sha_req_ctx.

Also, now that struct sa_tfm_ctx *ctx is removed from
struct sa_crypto_data, the forward declaration near the top of
drivers/crypto/sa2ul.h is no longer needed:

    #define SA_ENGINE_STATUS		0x0008
    #define SA_ENGINE_ENABLE_CONTROL	0x1000

    struct sa_tfm_ctx;

And in struct sa_req in drivers/crypto/sa2ul.c, the cmdl member is also
never read or written anywhere in the driver.

Could the commit message be updated to mention removing unused struct
members, and should the unused struct sa_tfm_ctx forward declaration and
sa_req::cmdl field be removed as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-b4-upstream-sa2ul-cleanup-v2-0-15ab90b3f9c2@ti.com?part=7