Re: [PATCH] crypto: sun8i-ce - Add AES-XTS for the H616

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] crypto: sun8i-ce: missing CRYPTO_XTS select fails
  sun8i_ce_cipher_init()
--

commit 660524c38c775c4edff2e13f8df35a02b4667a78
Author: Arun Iyengar <aiyengar1990@gmail.com>

crypto: sun8i-ce - Add AES-XTS for the H616

This commit adds AES-XTS support for the Allwinner H616 crypto engine
using its RAES unit and registers xts-aes-sun8i-ce with a fallback
transform.

> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> index 21762bd408e54..a7d771927b7a1 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c

[ ... ]

> @@ -350,6 +350,36 @@ static struct sun8i_ce_alg_template ce_algs[] = {
>  		.do_one_request = sun8i_ce_cipher_do_one,
>  	},
>  },
> +{
> +	.type = CRYPTO_ALG_TYPE_SKCIPHER,
> +	.ce_algo_id = CE_ID_CIPHER_AES,
> +	.ce_blockmode = CE_ID_OP_XTS,
> +	.alg.skcipher.base = {
> +		.base = {
> +			.cra_name = "xts(aes)",
> +			.cra_driver_name = "xts-aes-sun8i-ce",
> +			.cra_priority = CE_PRIO_BELOW_CPU,
> +			.cra_blocksize = AES_BLOCK_SIZE,
> +			.cra_flags = CRYPTO_ALG_TYPE_SKCIPHER |
> +				CRYPTO_ALG_ASYNC |
> +				CRYPTO_ALG_NEED_FALLBACK,
> +			.cra_ctxsize = sizeof(struct sun8i_cipher_tfm_ctx),
> +			.cra_module = THIS_MODULE,
> +			.cra_alignmask = 0xf,
> +			.cra_init = sun8i_ce_cipher_init,

[Severity: Medium]
Should CRYPTO_DEV_SUN8I_CE in drivers/crypto/allwinner/Kconfig select
CRYPTO_XTS alongside CRYPTO_ECB and CRYPTO_CBC?

sun8i_ce_cipher_init() unconditionally calls
crypto_alloc_skcipher("xts(aes)", 0, CRYPTO_ALG_NEED_FALLBACK) to allocate
op->fallback_tfm, which fails with -ENOENT during registration self-tests
or transform allocation when CONFIG_CRYPTO_XTS is disabled and no other
xts(aes) implementation is built in.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-sun8i-ce-h616-xts-v1-1-2fff3eb0807a@gmail.com?part=1