Re: [PATCH v2 6/6] firmware: qcom: scm: Drop exported ICE wrapper functions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] firmware: qcom: scm: missing @dev in ICE helper kernel-doc
  comments
--

commit 7bfa90e5e53a6765c06df911105e2ee2369b3560
Author: Harshal Dev <harshal.dev@oss.qualcomm.com>

firmware: qcom: scm: Drop exported ICE wrapper functions

This commit removes the exported ICE wrapper functions from the SCM driver
and renames the internal static helpers now that the ICE driver uses the TZ
agnostic ICE APIs.

> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> index 6b66bcedc84fd..277334f71178d 100644
> --- a/drivers/firmware/qcom/qcom_scm.c
> +++ b/drivers/firmware/qcom/qcom_scm.c
> @@ -1399,25 +1399,20 @@ int qcom_scm_ocmem_unlock(enum qcom_scm_ocmem_client id, u32 offset, u32 size)
>  }
>  EXPORT_SYMBOL_GPL(qcom_scm_ocmem_unlock);
>  
> -bool __qcom_scm_ice_available(struct device *dev)
> -{
> -	return __qcom_scm_is_call_available(dev, QCOM_SCM_SVC_ES,
> -					    QCOM_SCM_ES_INVALIDATE_ICE_KEY) &&
> -		__qcom_scm_is_call_available(dev, QCOM_SCM_SVC_ES,
> -					     QCOM_SCM_ES_CONFIG_SET_ICE_KEY);
> -}
> -
>  /**
>   * qcom_scm_ice_available() - Is the ICE key programming interface available?
> + * @dev: The SCM device
>   *
>   * Return: true iff the SCM calls wrapped by qcom_scm_ice_invalidate_key() and
>   *	   qcom_scm_ice_set_key() are available.
>   */
> -bool qcom_scm_ice_available(void)
> +static bool qcom_scm_ice_available(struct device *dev)
>  {
> -	return __qcom_scm_ice_available(__scm->dev);
> +	return __qcom_scm_is_call_available(dev, QCOM_SCM_SVC_ES,
> +					    QCOM_SCM_ES_INVALIDATE_ICE_KEY) &&
> +		__qcom_scm_is_call_available(dev, QCOM_SCM_SVC_ES,
> +					     QCOM_SCM_ES_CONFIG_SET_ICE_KEY);
>  }
> -EXPORT_SYMBOL_GPL(qcom_scm_ice_available);
>  
>  /**
>   * qcom_scm_ice_invalidate_key() - Invalidate an inline encryption key
> @@ -1431,7 +1426,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_ice_available);
>   *
>   * Return: 0 on success; -errno on failure.
>   */
> -static int __qcom_scm_ice_invalidate_key(struct device *dev, u32 index)
> +static int qcom_scm_ice_invalidate_key(struct device *dev, u32 index)

[Severity: Low]
Should the kernel-doc comments for qcom_scm_ice_invalidate_key(),
qcom_scm_ice_set_key(), qcom_scm_derive_sw_secret(),
qcom_scm_generate_ice_key(), qcom_scm_prepare_ice_key(), and
qcom_scm_import_ice_key() also document @dev like qcom_scm_ice_available()
above?  Renaming these static helpers to match the preceding kernel-doc
blocks without documenting @dev causes W=1 kernel-doc warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-ice-migrate-tee-svc-v2-0-29d19f6c92ab@oss.qualcomm.com?part=6