From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>,
dm-devel@lists.linux.dev, Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH] crypto: crct10dif - remove from crypto API
Date: Thu, 06 Feb 2025 12:50:02 -0500 [thread overview]
Message-ID: <yq1r04b9d56.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250206173857.39794-1-ebiggers@kernel.org> (Eric Biggers's message of "Thu, 6 Feb 2025 09:38:57 -0800")
Eric,
> Remove the "crct10dif" shash algorithm from the crypto API. It has no
> known user now that the lib is no longer built on top of it. It has no
> remaining references in kernel code. The only other potential users
> would be the usual components that allow specifying arbitrary hash
> algorithms by name, namely AF_ALG and dm-integrity. However there are
> no indications that "crct10dif" is being used with these components.
> Debian Code Search and web searches don't find anything relevant, and
> explicitly grepping the source code of the usual suspects (cryptsetup,
> libell, iwd) finds no matches either. "crc32" and "crc32c" are used in
> a few more places, but that doesn't seem to be the case for
> "crct10dif".
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2025-02-06 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 17:38 [PATCH] crypto: crct10dif - remove from crypto API Eric Biggers
2025-02-06 17:50 ` Martin K. Petersen [this message]
2025-02-06 18:04 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r04b9d56.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=ardb@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox