From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [v2 PATCH] crc-t10dif: Fix potential crypto notify dead-lock
Date: Mon, 08 Jun 2020 21:28:27 -0400 [thread overview]
Message-ID: <yq1sgf5rpta.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200605065918.GA813@gondor.apana.org.au> (Herbert Xu's message of "Fri, 5 Jun 2020 16:59:18 +1000")
Herbert,
> The crypto notify call occurs with a read mutex held so you must not
> do any substantial work directly. In particular, you cannot call
> crypto_alloc_* as they may trigger further notifications which may
> dead-lock in the presence of another writer.
>
> This patch fixes this by postponing the work into a work queue and
> taking the same lock in the module init function.
No particular objections to this approach from me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-06-09 1:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 6:33 [PATCH] crc-t10dif: Fix potential crypto notify dead-lock Herbert Xu
2020-06-05 5:40 ` Eric Biggers
2020-06-05 6:49 ` Herbert Xu
2020-06-05 6:59 ` [v2 PATCH] " Herbert Xu
2020-06-05 18:22 ` Eric Biggers
2020-06-05 18:25 ` Herbert Xu
2020-06-05 18:48 ` Eric Biggers
2020-06-08 6:25 ` Herbert Xu
2020-06-05 18:45 ` Eric Biggers
2020-06-08 6:26 ` Herbert Xu
2020-06-09 1:28 ` Martin K. Petersen [this message]
2020-06-10 6:42 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sgf5rpta.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).