From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105B023BCFF for ; Thu, 8 Jan 2026 02:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767839033; cv=none; b=DeLLf3e/B1Vt9BQHhXcfo7IrCY7fgklFNosskHx+2VYC3BXKdUE3l5EmSQRXKyyCxoeMPU2IOCkqQ464OKpw+U3psU+jqQvJ5BVmukbwGaf0RhhyEUQGeY1DoxfSNgknQmY0q1j6SNlLapEcxHvcc15ejUZduHjwE4DTVgmJBGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767839033; c=relaxed/simple; bh=ZDpPQWr5z3NT2bQ1AQqz7QtzavFPv5XMuiJ4qVKOIms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IT53UAkba+IuF8WEcEnk3dA6MphWPqaYV+LyNczQZPJnb68WE724xd5QabMge/Zp1ExbfXko3UdEJ5fVGeoucu4JfSrApHqgTlwMP7PXF9aHtxXg0+B/IuS5wSjAjhwsI9FpJfIQrEKckfWVB1rWshrN1X3Lec9iG8fHBHqDidk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MGb3dmaD; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MGb3dmaD" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-78fc4425b6bso28748627b3.1 for ; Wed, 07 Jan 2026 18:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767839029; x=1768443829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6WPMqEgbiq/1nCGoqJgHIPGVbxZP1MvEMarO5Hdi07w=; b=MGb3dmaDQKsX//2UaMn18UEyPEVVOrwpxvgc2plAE81AZgWHrrAgPjTatOAPslaTB5 EfQ5rgoTupA4yNHOh7kI082eN62vYdquEf+7Cxn9HonhYZ2JfJOVkG+0GqmUlWz4+R0q NShQVulSEA7CR8bEiX2zr4wBM4g55McgeeGcJbmFP+GlF3NxbnNvA0pz9vdS54zmM5ZY fP2HHaeUXBjYV20GVogADu5n3l11A34uA+a+JZUmfBKNg9s7AtPxn875jkeRmjVgxqWl 4QO129EL8ru8/vAukdfLmGvUSTHOsynYrp8RzC4QWYZwB5sFp2xWTbnboRzQofpJDx8p cWVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767839029; x=1768443829; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6WPMqEgbiq/1nCGoqJgHIPGVbxZP1MvEMarO5Hdi07w=; b=GI6aStC39mlCQvxcQmpibrm6V4q/TEvjj1lK6/dT9rvXmXguuFujGYWZRii9q2SOjT Ow/MjZD0vP34jIhJVsCxIqrjPJHg5nAIdzOscu1VkpnjNKbLAJs+P+XrHjOh+obys1pK kx4Z117HqzhI0TuPruij6+hgRaViIHi5JU3wTPtLY/UI0Sv0uxg9gpnhXNbuoJifwrkF PjDIbqzobQod2kchdMQcE4xSeNaT6MSJT84yqt3FL8DqLj/9jrDBZM89htuM7u7mufri 9kd0HZJXIliktFeNBkJ7n27v2jBLZqfFn5K7trpMMGpiolNsIdafOKFXVadWPxC6x03x t/vA== X-Forwarded-Encrypted: i=1; AJvYcCV2/C3cwYyfaTZeH2KDbKaLHqT53NYjMxDY3P6nvkjK4/WBj5u8yuTCBNy8TKtMaR0puHNA4C9DuxJF@vger.kernel.org X-Gm-Message-State: AOJu0YwDASXSAEboysz/kKzSu/cDsfGBeZW9urVlOqo5MLM6k0PjFimf HEh+L+LTtVhL7NfrEy3wJcc8hxg8x3OmJuZwculd9g8/c83R6mMgJ2Sc X-Gm-Gg: AY/fxX5Mc5geKFG7SNFKvq6QSq4DEiww8Vlg/JNiuGI8N98hFR4GGXvTOk/01PqUAHa ufOrw8Ljyuz/0IzEbF2b+eYvZXuvE7l/4G/sgt5WMfK0e0dHGYvx8NmYrsmmf+1Q3fOjyl1PY74 f9R8KuJvs5o3SHYnxxMA2WTqcbzYvb42MvApdg1SWUXypXRKzTAVxK4OaNk1qCROQ0anICNK75c JwQfgdEl8Q3UMMzdoQbUKS0MfkDQCk9OXKqcRjI6M/BGr9582fP/u/pcy3ZYyKnFIRflEYXIAp1 roslCJKkfNhuMo1v7In+g0FiAgic9axVQf9z6SLCgVg+3fJsbI2qGsUbcOevGtW8KcNAXzN/NTM oPPmOz9qaMsHGfbJApS/aDvSMWi/g+cnfJx4QgAEKuZlDB7YWTUEdQocyLy574v0wUG3KQe9nQS BHVISbruPTPVioDBoPBuER01Zqxa6YQgMhRF1Brw== X-Google-Smtp-Source: AGHT+IGgMpL+kZMdvF4ADTgetvjR8KjnRPwe3Xe2CKlVvJLk69qHA2NQZ4MxPPVQYhnVGWyKjWzQjw== X-Received: by 2002:a05:690e:1c06:b0:644:6b68:f126 with SMTP id 956f58d0204a3-64716cacb29mr3927712d50.77.1767839028925; Wed, 07 Jan 2026 18:23:48 -0800 (PST) Received: from [192.168.2.226] (104.194.78.75.16clouds.com. [104.194.78.75]) by smtp.gmail.com with ESMTPSA id 00721157ae682-790ae603282sm21321087b3.13.2026.01.07.18.23.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 18:23:48 -0800 (PST) Message-ID: <1d110134-89ab-474b-bca6-cfbfd4b5057f@gmail.com> Date: Thu, 8 Jan 2026 10:23:19 +0800 Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pgtable: convert pgtable_t to ptdesc pointer To: Matthew Wilcox Cc: Mike Rapoport , alexs@kernel.org, Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Russell King , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "open list:ALPHA PORT" , open list , "open list:SYNOPSYS ARC ARCHITECTURE" , "moderated list:ARM PORT" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:C-SKY ARCHITECTURE" , "open list:QUALCOMM HEXAGON ARCHITECTURE" , "open list:LOONGARCH" , "open list:M68K ARCHITECTURE" , "open list:MIPS" , "open list:OPENRISC ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:RISC-V ARCHITECTURE" , "open list:SUPERH" , "open list:USER-MODE LINUX (UML)" References: <20260107064642.15771-1-alexs@kernel.org> <080e493a-e4f1-4c97-a3e1-f76f126b5213@gmail.com> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026/1/7 22:48, Matthew Wilcox wrote: > On Wed, Jan 07, 2026 at 05:28:36PM +0800, Alex Shi wrote: >> Right, I will fix this. and sent the 2nd version. > No, the patch is stupid and wrong. Don't send a v2. You seem to have a > hairtrigger resend, so I'm trying to prevent a v2 being sent instead of > sending a patient reply. Hi Matthew, I hear you—no v2 will be sent. but sorry for a bit confusing, what's your expected fix? is the too quick resenting? or the direction to alignment pgtable_t with ptdesc is wrong? If it's the first. the new change for review address Mike's concern. diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h index a17f01235c29..a204c3ac800a 100644 --- a/arch/arm/include/asm/pgalloc.h +++ b/arch/arm/include/asm/pgalloc.h @@ -94,13 +94,13 @@ pte_alloc_one_kernel(struct mm_struct *mm) static inline pgtable_t pte_alloc_one(struct mm_struct *mm) { - struct page *pte; + struct ptdesc *pte; pte = __pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM); if (!pte) return NULL; - if (!PageHighMem(pte)) - clean_pte_table(page_address(pte)); + if (!PageHighMem(ptdesc_page(pte))) + clean_pte_table(ptdesc_address(pte)); return pte; } @@ -141,7 +141,7 @@ pmd_populate(struct mm_struct *mm, pmd_t *pmdp, pgtable_t ptep) else prot = _PAGE_USER_TABLE; - __pmd_populate(pmdp, page_to_phys(ptep), prot); + __pmd_populate(pmdp, page_to_phys(ptdesc_page(ptep)), prot); } #endif /* CONFIG_MMU */