From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URI_HEX,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DF6C2D0DB for ; Sun, 26 Jan 2020 15:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78E752071A for ; Sun, 26 Jan 2020 15:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725908AbgAZPfC convert rfc822-to-8bit (ORCPT ); Sun, 26 Jan 2020 10:35:02 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:30268 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgAZPfC (ORCPT ); Sun, 26 Jan 2020 10:35:02 -0500 Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:383c:9d3:6333:ab7c]) (Authenticated sender: yann.morin.1998) by smtp2-g21.free.fr (Postfix) with ESMTPSA id D700A20040F; Sun, 26 Jan 2020 16:34:43 +0100 (CET) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sun, 26 Jan 2020 16:34:43 +0100 Date: Sun, 26 Jan 2020 16:34:43 +0100 From: "Yann E. MORIN" To: Thomas De Schampheleire Cc: Mao Han , xianmiao_qu@c-sky.com, ren_guo@c-sky.com, linux-csky@vger.kernel.org, hongdeng_chen@c-sky.com, thomas.petazzoni@bootlin.com, buildroot Subject: Re: [Buildroot] [PATCH 1/2] package/toolchain-external: ensure ARCH_LIB_DIR exist Message-ID: <20200126153443.GP32369@scaer> References: <1577937441-18703-1-git-send-email-han_mao@c-sky.com> <20200113033451.GA15150@vmh-VirtualBox> <20200117023547.GA12999@vmh-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Mao, All, On 2020-01-24 16:00 +0100, Thomas De Schampheleire spake thusly: > El vie., 17 ene. 2020 a las 3:35, Mao Han () escribió: [--SNIP--] > > There is another patch in the same thread: > > [PATCH 2/2] toolchain: Get ld.so name if available > > http://buildroot-busybox.2317881.n4.nabble.com/PATCH-1-2-package-toolchain-external-ensure-ARCH-LIB-DIR-exist-td243604.html#a244193 > > Tried to get the corresponding ld.so name with certain configuration. > Thanks. Using this patch '[PATCH 2/2] toolchain: Get ld.so name if > available' I actually can compile correctly. > So, PATCH 1/2 is not actually needed. > > Do you agree that only PATCH 2/2 is required? > If so I will perform a more thorough review of that patch. Given the feedback from Thomas, and the coments I provided on the second patch, I've marked the two patches as Changes Requested on patchwork. Thank you! :-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'