From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B55374197 for ; Thu, 22 Jan 2026 16:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100869; cv=none; b=hHvmslMmAi+qhyORRrhmW5nmpM1RS0NdjFqf5KbtqnECQUuyPwpbGulbFRxmcu5XCnZWlYBXam70dTQlc0yG5Br+JFPG/ovBxWpsIgRnJWpQWVeXKo/zUEzN43LLUFaxFfjR2HxdUVEnn3UloyNODD+AAm/hkcY5zjSW9/DoJ2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100869; c=relaxed/simple; bh=tI6CnFHFGW2mHe/ilKBHMpKa7DzCNr0AjpSz8C0GdXU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=dNqyVHBgs92ZkQS91HrkxMfT8oTKFaLjRoNgYf4DBOSbMSGkZgXS490/YY6tJ2yJ0UOtS9i1+oGmRYse7n5FGU27MuCk30YvKQY7hyhLkcOQphEolrE0YXZY4fT5fWB4eafXAcFlbclAlq1T+DgohgkGJTWBNh2iJt2CcuO+oCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hFPF4O7L; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hFPF4O7L" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2b722bc1be1so932872eec.0 for ; Thu, 22 Jan 2026 08:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769100855; x=1769705655; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=ptohnX8yCM46UmZak3D8AP5tKkb3cPUe+4O8l8XtsLs=; b=hFPF4O7LLQhPU1E679fOzOI7s0dlGyeS4TGkUMe4ePXneJ2Eun6r4wcw8gfh/1w03A go5yG12geARak4vsCQusXYhx2wNgyzEUUmKFU+z/JSSvXXS03tQGYnAWFxN5S1+SwICA vaHd9T6ro4ZstNQ3uLWrQ83CTKWY7CGytTPZsumk2nM6zMdCkmSiTd26/7JtKfLhvrqa DlOxFmy/5u4F5/nj4+xt0hP9SQhQE+oFWwnRcsQJsehtkCDAI2EO1aOvDDN6Nr2UFsc2 z7CHVagvS+L+cUgLn6hlgzlhv7xedqvevYGQzLTIMCGix3hF8d5+i2jCQ8rabP/Bzi0l k4gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769100855; x=1769705655; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ptohnX8yCM46UmZak3D8AP5tKkb3cPUe+4O8l8XtsLs=; b=jHDet0kh9jjniGywTEHSwzqBaNZb0BqoIPr+p3p00+BjDvNLeZLM+EhCo7mepVZbVl Vq3es0H6loh3+ApgmRNxTHeyDRHxcMb7KbdM3DpEooQTwUn3LgEDv3W8Gxt96Fy/SUv1 uW+ugvsdg71Us7TjjQ5dh1VBxaGYN9Dmt1nTPyWQFe65JuCDWLwlCy5qI5zwPV//ojd5 xtbJ6Tn4o/uEJ1ovwDnhOWWmEq5EwfsiJxqJMeR7iwSNQoZVEhkHmL3PftBGfhTz/y1z fzcnCk06R6MmpwD82ls7TNpAPXq375n1Swq6vS3negjf5Bhqf8TJK/62HJWOXtiVQRq3 qrvA== X-Forwarded-Encrypted: i=1; AJvYcCXpPevmZTehph5kWp5TEkbKcROW5InSRlluOnd8bz5BUVuUinAbREZFnEq4HHQx2w3zMtG4YeEUdLZ2@vger.kernel.org X-Gm-Message-State: AOJu0YyE+bcQcknokEJKPalBAqOtHo+QaAxvlYAoiOFMY54fUpEaCfnh 6Sp1cyd6IMpKlwLeosFPl+2E9iAg0jVxHZRVHo+f7pT4p50Dy+6nrOIAQ4OuWIAIudvg9i5iIbk HOBBfAK8cbw== X-Received: from dybgn17.prod.google.com ([2002:a05:7301:2511:b0:2b7:3bb:5997]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:650c:b0:2ae:51ae:5cfd with SMTP id 5a478bee46e88-2b6b4104264mr16128244eec.22.1769100854683; Thu, 22 Jan 2026 08:54:14 -0800 (PST) Date: Thu, 22 Jan 2026 08:53:55 -0800 Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260122165407.561888-1-irogers@google.com> Subject: [PATCH v2 00/12] perf annotate arch clean up From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , Will Deacon , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zecheng Li , Tianyou Li , Thomas Falcon , Julia Lawall , Suchit Karunakaran , Athira Rajeev , Aditya Bodkhe , Howard Chu , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Shimin Guo , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" 3 initial memory leak fix patches for perf annotate. Move the disasm.c #included arch files into a new util/annotate-arch directory. Make the code compile standalone. Try to better encapsulate architecture specific code within the files and with a arch__new_ function that allows additional data to be associated with the struct arch using the standard container_of trick. Make the lookup of struct arch use the ELF machine gather from a thread rather than an evsel. For example, the evsel can't determine the difference between EM_386 and EM_X86_64 so generally the latter has currently been used. This means the dwarf registers are off as register 1 is CX with EM_386 and DX with EM_X86_64. To facilitate this change map_symbol is refactored to use a struct thread rather than a struct maps, the maps being obtainable from the thread. To make in and out arguments clearer, for safety, etc. try to constify struct arch and its related structs. v2: Add a patch to fix a domain info memory leak that was blocking leak sanitizer analysis. Fix more map_symbol leaks or uses after reference count put (Suchit Karunakaran ). Try to repro annotate test crash (James Clark) but suspect it was addressed in the other reference count fixes. v1: https://lore.kernel.org/lkml/20260122073127.375139-1-irogers@google.com/ Ian Rogers (12): perf header: Fix memory leaks in process_cpu_domain_info perf annotate: Fix args leak of map_symbol perf maps: Fix reference count leak in maps__find_ams perf disasm: Constify use of struct arch perf disasm: Constify use of struct ins_op perf disasm: Constify use of struct ins perf disasm: Rework the string arch__is to use the ELF machine perf disasm: Don't include C files from the arch directory perf disasm: Refactor ins__is_call/jump to avoid exposing arch ins_ops perf map_symbol: Switch from holding maps to holding thread perf disasm: Refactor arch__find and initialization of arch structs perf disasm: Minor layout tweaks for struct arch tools/perf/arch/arc/annotate/instructions.c | 11 - .../perf/arch/riscv64/annotate/instructions.c | 36 -- tools/perf/ui/browsers/annotate.c | 6 +- tools/perf/ui/browsers/hists.c | 3 +- tools/perf/util/Build | 1 + tools/perf/util/addr_location.c | 4 - tools/perf/util/addr_location.h | 1 - tools/perf/util/annotate-arch/Build | 11 + tools/perf/util/annotate-arch/annotate-arc.c | 18 + .../annotate-arch/annotate-arm.c} | 48 +- .../annotate-arch/annotate-arm64.c} | 59 +-- .../annotate-arch/annotate-csky.c} | 29 +- .../annotate-arch/annotate-loongarch.c} | 71 +-- .../annotate-arch/annotate-mips.c} | 29 +- .../annotate-arch/annotate-powerpc.c} | 125 ++++- .../util/annotate-arch/annotate-riscv64.c | 41 ++ .../annotate-arch/annotate-s390.c} | 70 +-- .../annotate-arch/annotate-sparc.c} | 26 +- .../annotate-arch/annotate-x86.c} | 89 ++-- tools/perf/util/annotate-data.c | 12 +- tools/perf/util/annotate-data.h | 2 +- tools/perf/util/annotate.c | 88 ++-- tools/perf/util/annotate.h | 10 +- tools/perf/util/callchain.c | 12 +- tools/perf/util/capstone.c | 18 +- tools/perf/util/db-export.c | 1 - tools/perf/util/disasm.c | 428 +++++++----------- tools/perf/util/disasm.h | 95 ++-- tools/perf/util/event.c | 2 - tools/perf/util/header.c | 17 +- tools/perf/util/hist.c | 18 +- tools/perf/util/llvm.c | 8 +- tools/perf/util/machine.c | 13 +- tools/perf/util/map_symbol.c | 5 +- tools/perf/util/map_symbol.h | 3 +- tools/perf/util/maps.c | 1 + tools/perf/util/sort.c | 2 +- tools/perf/util/unwind-libdw.c | 2 +- tools/perf/util/unwind-libunwind-local.c | 2 +- 39 files changed, 774 insertions(+), 643 deletions(-) delete mode 100644 tools/perf/arch/arc/annotate/instructions.c delete mode 100644 tools/perf/arch/riscv64/annotate/instructions.c create mode 100644 tools/perf/util/annotate-arch/Build create mode 100644 tools/perf/util/annotate-arch/annotate-arc.c rename tools/perf/{arch/arm/annotate/instructions.c => util/annotate-arch/annotate-arm.c} (59%) rename tools/perf/{arch/arm64/annotate/instructions.c => util/annotate-arch/annotate-arm64.c} (70%) rename tools/perf/{arch/csky/annotate/instructions.c => util/annotate-arch/annotate-csky.c} (67%) rename tools/perf/{arch/loongarch/annotate/instructions.c => util/annotate-arch/annotate-loongarch.c} (60%) rename tools/perf/{arch/mips/annotate/instructions.c => util/annotate-arch/annotate-mips.c} (59%) rename tools/perf/{arch/powerpc/annotate/instructions.c => util/annotate-arch/annotate-powerpc.c} (73%) create mode 100644 tools/perf/util/annotate-arch/annotate-riscv64.c rename tools/perf/{arch/s390/annotate/instructions.c => util/annotate-arch/annotate-s390.c} (66%) rename tools/perf/{arch/sparc/annotate/instructions.c => util/annotate-arch/annotate-sparc.c} (85%) rename tools/perf/{arch/x86/annotate/instructions.c => util/annotate-arch/annotate-x86.c} (93%) -- 2.52.0.457.g6b5491de43-goog