From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f35.google.com (mail-wr2-f35.google.com [74.125.225.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0067B49DB87 for ; Wed, 23 Sep 2026 10:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790160203; cv=none; b=EiXhsQjf5D0E9uVm5FJC6GMMIfvaWkN4O1Z2SwEOpSlryYYdHmkAyXDupPr23gIViArWuPKYqyuSqnkIGG6hMiIa3sqwY0zHWfUFVhd7Au6YthftWtwWSg4yUCKQaO8srC7JZY2tRrQ4jHaRzyFHXZLmAj8N8cigSjZ1YRPwerg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790160203; c=relaxed/simple; bh=/hAmY6yG2+OCPMJTvRs5ChswnMAkCdLCUN+/9Q9fZh4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mlz586N+DKgLDw/f4i5J68IWm78/Jex+/cn3uKT3cVCjIfmIYlHusoORwEVM+5hnQQeTxhBslVDqnNTKAP6CVjfw04s9fPUfsTyhjw2zWsT4tAQKOzVwZ+lzvPlE5UoYtbL857PHCalPjnZDjTmC7HMvOGMS6NxqIgNqEmVlHRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CPn+PcDu; arc=none smtp.client-ip=74.125.225.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CPn+PcDu" Received: by mail-wr2-f35.google.com with SMTP id ffacd0b85a97d-4885d4825adso509528f8f.0 for ; Wed, 23 Sep 2026 03:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790160195; x=1790764995; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=t1Z4i78iFUVYmXdwkSYq7EkiOAX8N+OcOOj8F5FsldA=; b=CPn+PcDupM2GLmmXqlMvdfReA/3wAJMMUSYOaS0cjHThc+wAddPU6ProYKR6TX3Op8 s5yp4NHCPEyjnz7+u4HLA0GZuhA0Oj8otUoWv8l47UgGGRHC7RB+QKgleMtdEGjeacfa cwEabG/Wu8LWuc8bIYyGd5xPBPTKhj+h6H/S0tmTY0FALjfJyBWvjhnn/7VulmBeSwdo kCPPPwzI8RbocchihueTj+H9IkBO631KrCldStcev3UFlDv2I9e43Sa0IglFTP0ilagV IGoXnifX2h3lYXLiIng8I1BlirUsIfWEbUsc2wBKREgeXUo6mN+LqTu5n8+SmdxH3DVi 7McQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790160195; x=1790764995; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t1Z4i78iFUVYmXdwkSYq7EkiOAX8N+OcOOj8F5FsldA=; b=0bjn6VaszIVkeMiGYuXCGTGo6SZUsJ0KN9LRiDW4yrt9xdz/25hKnkdvOt1z7QgvwI OkBzwywf8pV8YzHu5oa/WrHxlmA8FjXDoc5IWlrt9Mvh/4GbyJ/MjeSD4CUt0FkyUV2G ikNHUCcaql5dM61rpC6LjEVgklsekGP8q3NcEtSzMkmyD0jOXKgte3jav/+RR2xCkOvs NmEg4bO9rfTfbi41VpQFezctMKAjd0FQ8bkvkZjE3ldNUmLnxnTHdQtzsOUxakXxdwgU k0Mvpbh7m3huRRsdnKlfl7lOhg/4DL07tJtsW0ElKcy6vVIxe1zt88f+wZNxgbLtXJ3J y9ww== X-Forwarded-Encrypted: i=1; AKwUvBzRfzRGOGNyX3/Dx4fONrVowL3qmlybYyxcRolGdGHnSaHe0exOXZ3WNUXGYCuFnd7wzLEPrzoE7aK6@vger.kernel.org X-Gm-Message-State: AFuF++lgpEFOvPA8r0klJTO3U11wHGGODw/8lNd+gKGDL+98ksQ/kdMz pD0ST3oq/yn9f5ClI2Q5iY4O4o2IF2HLyFy/OAsk/9Sn3fQsHJsTRizS X-Gm-Gg: AYBFou3UWss2cBrkGhkRuOQ0ssnXUlC1W0zncI9pa0emsfCOJJH23OIYcQE78hR0ZVJ bTmq8EuaAG0xezVNissNrFkXc9VGc92DP/xkNtDfFJ0XfqJJqcxUsdTRnVbz1JlkdWOPJWMQeJs VHWHjMfeGmtcoJe9kkULw/NohDHcXfFrCwUVbX4/UB2cJJWfG1yeZQ4IWh0m8SBj6xKWbVDVy83 YZ7+ayC0v5RDpQgDUI8V9/CcWJtgqoCDBXMl7JRFrbJCWzmwAHkPCuVj+i+mnEzcd8Vas4oglp1 OObwe614KV8EB8YLB1jHb1FXUImfKToZdktkyTZ0sC5koXYDMKKf3vyH8+el6GGjx1UQH5m3YJ3 Q0xWoGT+AzdgW0dcyesX1fseBzt8ffF6HLBrrtKHuX5SbxYckK7/rQJpQpw9PaG0XCsv0k0ppLX oLH9LQydmbpqNF8B/HBonQQTAkzWXTEQwnkhQVK7n+P+y0vnbIzDAEqqnh6INGSF2SSiDH0m3jD TsW/plHY7yyIvx3OjgU1nqPW/mLDJX/kLWRA3EbyAsSsg== X-Received: by 2002:a5d:64cc:0:b0:487:81c:6de with SMTP id ffacd0b85a97d-48867093ce7mr3896298f8f.34.1790160194918; Wed, 23 Sep 2026 03:43:14 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-488687791cdsm5534038f8f.22.2026.09.23.03.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 03:43:14 -0700 (PDT) Date: Wed, 23 Sep 2026 11:43:13 +0100 From: David Laight To: Bradley Morgan Cc: "Paul E. McKenney" , frederic@kernel.org, neeraj.upadhyay@kernel.org, boqun@kernel.org, joelagnelf@nvidia.com, rcu@vger.kernel.org, "Andrew Morton" , "Arnd Bergmann" , linux-arch@vger.kernel.org, "Vineet Gupta" , linux-snps-arc@lists.infradead.org, "Russell King" , linux-arm-kernel@lists.infradead.org, "Guo Ren" , linux-csky@vger.kernel.org, "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" , linux-sh@vger.kernel.org, "Chris Zankel" , "Max Filippov" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] lib: Add two-byte cmpxchg emulation function Message-ID: <20260923114313.75494970@pumpkin> In-Reply-To: <20260911192540.20983-2-brads@mainlining.org> References: <20260911192540.20983-1-brads@mainlining.org> <20260911192540.20983-2-brads@mainlining.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 11 Sep 2026 19:25:34 +0000 Bradley Morgan wrote: > cmpxchg_emu_u8() emulates one-byte cmpxchg() in terms of four-byte > cmpxchg() for the architectures lacking native one-byte atomics. > The same architectures also lack native two-byte cmpxchg(), where > such an operation is not supported and either fails to compile via > BUILD_BUG() or fails to link, because the bad pointer sentinels > these architectures declare are never defined. > > Add cmpxchg_emu_u16(), the two-byte sibling. It reads the enclosing > word with READ_ONCE(), splices the two target bytes through a union > and loops on cmpxchg() of the full word until the compare succeeds. > Like cmpxchg_emu_u8() it is fully ordered. > > The Kconfig symbol gating this file is renamed from > ARCH_NEED_CMPXCHG_1_EMU to ARCH_NEED_CMPXCHG_1_2_EMU, as it now > selects both the one-byte and the two-byte emulation. > > Suggested-by: Paul E. McKenney > Signed-off-by: Bradley Morgan > --- > arch/Kconfig | 2 +- > arch/arc/Kconfig | 2 +- > arch/arm/Kconfig | 2 +- > arch/csky/Kconfig | 2 +- > arch/sh/Kconfig | 2 +- > arch/xtensa/Kconfig | 2 +- > include/linux/cmpxchg-emu.h | 1 + > lib/Makefile | 2 +- > lib/cmpxchg-emu.c | 35 ++++++++++++++++++++++++++++++++--- > 9 files changed, 40 insertions(+), 10 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 3bb2e568f5b1..d56064797e09 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -1817,7 +1817,7 @@ config CC_HAS_SANE_FUNCTION_ALIGNMENT > # strict alignment always, even with -falign-functions. > def_bool CC_HAS_MIN_FUNCTION_ALIGNMENT || CC_IS_CLANG > > -config ARCH_NEED_CMPXCHG_1_EMU > +config ARCH_NEED_CMPXCHG_1_2_EMU Is it actually worth the churn of changing the name? Maybe just a comment that say it adds both 1 and 2 byte emulation? David > bool > ...