From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B025D24A06D for ; Sun, 18 Jan 2026 08:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768724054; cv=none; b=bPfO9SEUZpERVDW8s8oB47E09NAGoz5FC6gr3LNbg7jen73UZOLXoKecChAzlsNEA3RdhtBQSuYYxE++jCep4H6nAfmm6Fnct8uixK4zh14hkWgiXSWLJSiBAP7fLvrjh9UXJASeNtYcpDwwL0i9DMc5e9NkW8lqJE107VYBZ6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768724054; c=relaxed/simple; bh=QgT2evQuj3cvQqRAA1G9AXLS+KHzWpz3urey0I2MaQM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=p0qtVGitZ+puAY8BIyD5gM1G95XgiPPKjWbwlQ1xX2l+E/5CvZqGyBFchWalIPbHlLVFqxi4h/9s5liydWjvEfqsHAKhToRj9iAfUZq3YlBW/7E4+XCBLTLfHT23ce4acVY6IvKCoe5finNOFD4ALsLkUAFMdY3IBOWyltAaCno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YzQ5aXSe; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YzQ5aXSe" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a2ea96930cso19804855ad.2 for ; Sun, 18 Jan 2026 00:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768724052; x=1769328852; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=X+fhLmMt6EbvGWzllqZJVhmHGvaT37bdUz8irugZaMU=; b=YzQ5aXSezflQSS4fyv6YrVmbfYKirEpnZcjFX8vKbHywdSy74iYS6281s9Keui7EAZ CQ5KoP6iC97nn7Kv0GsSObUSL2JQywB7nmYE676KDVv4XZKKf3hlx24Q7ny3bd8jpEJl gDuJ8d45gtLMWZYw4UJxjV39vcXirmfTu79baWdlAJlll6LfU4Mj9VzAHpfW2p5Bn0mz Kw0s7hbWKRT7+vEb79JxIrGc8laHKof/zs22o8Rff0TwpBUlD+Is2rYEPfhRcs+6MwIC Yqp50pTXO4z7pH/OINQ0KX7kFvDuxlNiVIV5M8DiZ3pAS6VD591IxrR81OcXia5FHQJW x5Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768724052; x=1769328852; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X+fhLmMt6EbvGWzllqZJVhmHGvaT37bdUz8irugZaMU=; b=xRU6e4mXrkwHr0zZf1RHfovSAbIosG0ZSZSbXV+NS2W6MMLjuOm5ZH2NwNz/qzy2NS WBQdfHAKolMXwirZUSPeTQmMEYl6i2K5V0oe2iEUyiwLo4WpuHw8d5AjdZPDLGYiaHKW lRtlXNnoYXE+vvlCgcZzw2LSBUNdLueHJ2lVJikghvsn6fpp5Y31WrNeyz/c/A067vdN gmqzUQGnjbR424HIUy/tB+nKtRnKyq73I2Jul+dJNLo4B9EkOZ5ru2X8VCn8wsXleom5 mQgTCjtN+mo67PTQ4IMFqGJlfIOytmn6wCnWcIstvKGMFh4zCtf2y7V44i8QQjTOaaoK GCkQ== X-Forwarded-Encrypted: i=1; AJvYcCUCYxlmUOtE9xPQGZZ2MQSNrAFpcIMm8NEHjgb/i7Tn5TIyB6IuxyjD8qhPaM6MdzlLutU1rgtgJyMZ@vger.kernel.org X-Gm-Message-State: AOJu0YzaRwwlAc/GVvWKqckAmey0Mv/yDbbMbobGIpPhOisMATuJwdJQ +ixdNfhDRCl4aRIAWOvmKSW9aafm05d7NRzIN08vW5R+mNOrdn+AciGu X-Gm-Gg: AY/fxX7Mm4ReM8i8JjhWuW1077+S7COusyaz5pfjC55rfKNBYK2l4FcQRmDsI3HW6gM HKZH3yz+tIQ8njZbrc80E4WpVrOyeJ2tVz5Pcn2niyD1wD/A1x/Yzgrap1zvIEgEhNvNy7XyL4E 2cb/HCGC2PXQLmT42wD0sqvi8pRy2eYuSXQfMqiCTJwvQRK4VAU1MUdkeinuroiwmWfTzzn7JZG uDmlKu/jil/B+LSOUAL2RS4yukY9PJh4i+tbo7imr8OxgRq3JmRvbYnD0ZhbScn6sOTtsilp7yJ hEhBR+8EFaJbaNtgV8pYfMKMwhptK57XV8OB9A4KcbyDKkHz7h7tJnWv81mIxmWhc48tpb21aka 4R0cSwzLl6RmlJ1oOwUSTZMQs6pTJvzVXQ8JOQoWYr/39ahVmQz54d2Jnwb8BtMwxdDAyHoiNMk 9dfoOjSxpu X-Received: by 2002:a17:903:40c5:b0:2a7:3dae:de9b with SMTP id d9443c01a7336-2a73daedf5fmr2287485ad.44.1768724051933; Sun, 18 Jan 2026 00:14:11 -0800 (PST) Received: from [192.168.2.226] ([114.92.45.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190abcf0sm63240195ad.12.2026.01.18.00.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jan 2026 00:14:11 -0800 (PST) Message-ID: <85a0be43-3598-435d-a50e-9403b7e963f7@gmail.com> Date: Sun, 18 Jan 2026 16:13:47 +0800 Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pgtable: convert pgtable_t to ptdesc pointer From: Alex Shi To: Matthew Wilcox Cc: Mike Rapoport , alexs@kernel.org, Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Russell King , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "open list:ALPHA PORT" , open list , "open list:SYNOPSYS ARC ARCHITECTURE" , "moderated list:ARM PORT" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:C-SKY ARCHITECTURE" , "open list:QUALCOMM HEXAGON ARCHITECTURE" , "open list:LOONGARCH" , "open list:M68K ARCHITECTURE" , "open list:MIPS" , "open list:OPENRISC ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:RISC-V ARCHITECTURE" , "open list:SUPERH" , "open list:USER-MODE LINUX (UML)" References: <20260107064642.15771-1-alexs@kernel.org> <080e493a-e4f1-4c97-a3e1-f76f126b5213@gmail.com> <1d110134-89ab-474b-bca6-cfbfd4b5057f@gmail.com> Content-Language: en-US In-Reply-To: <1d110134-89ab-474b-bca6-cfbfd4b5057f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026/1/8 10:23, Alex Shi wrote: > > > On 2026/1/7 22:48, Matthew Wilcox wrote: >> On Wed, Jan 07, 2026 at 05:28:36PM +0800, Alex Shi wrote: >>> Right, I will fix this. and sent the 2nd version. >> No, the patch is stupid and wrong.  Don't send a v2.  You seem to have a >> hairtrigger resend, so I'm trying to prevent a v2 being sent instead of >> sending a patient reply. > > Hi Matthew, > > I hear you—no v2 will be sent. > but sorry for a bit confusing, what's your expected fix? is the too > quick resenting? or the direction to alignment pgtable_t with ptdesc is > wrong? Hi Willy, Do you mind to share the detailed concern for this patch? Thanks > > If it's the first. the new change for review address Mike's concern. > diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/ > pgalloc.h > index a17f01235c29..a204c3ac800a 100644 > --- a/arch/arm/include/asm/pgalloc.h > +++ b/arch/arm/include/asm/pgalloc.h > @@ -94,13 +94,13 @@ pte_alloc_one_kernel(struct mm_struct *mm) >  static inline pgtable_t >  pte_alloc_one(struct mm_struct *mm) >  { > -       struct page *pte; > +       struct ptdesc *pte; > >         pte = __pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM); >         if (!pte) >                 return NULL; > -       if (!PageHighMem(pte)) > -               clean_pte_table(page_address(pte)); > +       if (!PageHighMem(ptdesc_page(pte))) > +               clean_pte_table(ptdesc_address(pte)); >         return pte; >  } > > @@ -141,7 +141,7 @@ pmd_populate(struct mm_struct *mm, pmd_t *pmdp, > pgtable_t ptep) >         else >                 prot = _PAGE_USER_TABLE; > > -       __pmd_populate(pmdp, page_to_phys(ptep), prot); > +       __pmd_populate(pmdp, page_to_phys(ptdesc_page(ptep)), prot); >  } > >  #endif /* CONFIG_MMU */