From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A76DC05027 for ; Fri, 3 Feb 2023 14:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233319AbjBCOcc (ORCPT ); Fri, 3 Feb 2023 09:32:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233661AbjBCOcU (ORCPT ); Fri, 3 Feb 2023 09:32:20 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CC839DEDE for ; Fri, 3 Feb 2023 06:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675434677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bBuUxRqwVpT90qSSvu23sLwWbKqZ02KC/SRu5tcTWNA=; b=HmrNQHKrlHkEXCpoxDcMZp7g/sMs3K+G4bVM9ILl0aZLjmuYpkeXh0a3CKcYFVFL6wX76/ S7QYF7/mqagVvRBqwWjCTrfwjOgoIs55l+wS4OQrnxUBNBFjW202VIXVuo80Co0umdeLJR f10/Thvc8+iGpjAN/Jx7MbZUeDOJs8E= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-606-_z3crPWrNBOLaTZ3olSk1w-1; Fri, 03 Feb 2023 09:31:15 -0500 X-MC-Unique: _z3crPWrNBOLaTZ3olSk1w-1 Received: by mail-wr1-f69.google.com with SMTP id e9-20020a5d6d09000000b002c172f173a9so709704wrq.17 for ; Fri, 03 Feb 2023 06:31:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bBuUxRqwVpT90qSSvu23sLwWbKqZ02KC/SRu5tcTWNA=; b=05uilyH/atUFzW0DWCL9Fhintu48Dt9m0VKsB5tyyDScZExD3Y6Ey3Ugp7+rV9H7p5 nip1MyvM7O1+ohS5EO1ktj0IqEMgALAq7DAhvjeZhe4XXp52G2z+li5YS+p8sOlOxmOH 3NUoEfN2owNf8MXh05ayOyBgSGcnPJQfWkCP7i1b9T6aQhmdQThpVzg1qyzY54/vYuLb yX8P4MnN4ia7J0Tl+w7NUre3zczc4wAtBH0RaDcx2zXu4qEa5tVyPNjZTaYrkdizJ8sv JiOMH927z4EZobkUg7Xxq0dFZ7QkFPlNSdfRYbn5oSkfih4j3CX2l0eY9f37Oj3h9cfu wFhQ== X-Gm-Message-State: AO0yUKWwhWAaOyeL2a+bU2LvvrL1BzwDEeqiRGeUu+GYgJUoz4WA+wDe Y7OBKH+Cv7+k0mwHd72OhAwu6tAPUnii3Ys2XLcBYY2ojoTzOAPvTx1Y4voUPu5NMJx3d8bJtt7 kcta3X+PxYV63gZ+xgEnHMg== X-Received: by 2002:a05:600c:4707:b0:3df:e6bb:768 with SMTP id v7-20020a05600c470700b003dfe6bb0768mr2347091wmo.24.1675434673745; Fri, 03 Feb 2023 06:31:13 -0800 (PST) X-Google-Smtp-Source: AK7set8jlKBL+3VH/Q/zFxtw4x3QAOrg1CgHYVk1aVg00PiHMhqeIMC/qbmUMqYVh9aDbNcRdczHvA== X-Received: by 2002:a05:600c:4707:b0:3df:e6bb:768 with SMTP id v7-20020a05600c470700b003dfe6bb0768mr2347047wmo.24.1675434673459; Fri, 03 Feb 2023 06:31:13 -0800 (PST) Received: from [192.168.3.108] (p5b0c6376.dip0.t-ipconnect.de. [91.12.99.118]) by smtp.gmail.com with ESMTPSA id w14-20020a05600c474e00b003dfe57f6f61sm2479833wmo.33.2023.02.03.06.31.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 06:31:12 -0800 (PST) Message-ID: <862cb71f-0775-916d-b0c9-5247f772d637@redhat.com> Date: Fri, 3 Feb 2023 15:31:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230129124235.209895-3-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On 29.01.23 13:42, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The MMU variant uses generic definitions of page_to_pfn() and > pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no > good reason. > > Include asm-generic/memory_model.h in the common include/asm/page.h and > drop redundant definitions. > > Signed-off-by: Mike Rapoport (IBM) > Reviewed-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb