Re: [PATCH v3 10/18] LoongArch: vDSO: Switch to generic storage implementation

Xi Ruoyao
2025-02-22T08:21:03Z

On Tue, 2025-02-04 at 13:05 +0100, Thomas Weißschuh wrote:
> The generic storage implementation provides the same features as the
> custom one. However it can be shared between architectures, making
> maintenance easier.
>
> Co-developed-by: Nam Cao <namcao@linutronix.de>
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Tested-by: Xi Ruoyao <xry111@xry111.site>

/* snip */

> diff --git a/arch/loongarch/include/asm/vdso/getrandom.h b/arch/loongarch/include/asm/vdso/getrandom.h
> index e80f3c4ac7481ba7f9f5d9210fefa78c3293243b..48c43f55b039b42168698614d0479b7a872d20f3 100644
> --- a/arch/loongarch/include/asm/vdso/getrandom.h
> +++ b/arch/loongarch/include/asm/vdso/getrandom.h

You can drop "#include <vdso/vdso.h>" in this file.

> @@ -28,11 +28,6 @@ static __always_inline ssize_t getrandom_syscall(void *_buffer, size_t _len, uns
>   return ret;
>  }
>
> -static __always_inline const struct vdso_rng_data *__arch_get_vdso_rng_data(void)
> -{
> - return &_loongarch_data.rng_data;
> -}
> -
>  #endif /* !__ASSEMBLY__ */
>
>  #endif /* __ASM_VDSO_GETRANDOM_H */

--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University