From: Guo Ren <guoren@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-csky@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] csky: Make HAVE_TCM depend on !COMPILE_TEST
Date: Fri, 17 Sep 2021 14:19:53 +0800 [thread overview]
Message-ID: <CAJF2gTSqKZKnUw-UQt5Tiag3T0D04dBW9FijaxPX7Q985=+j7w@mail.gmail.com> (raw)
In-Reply-To: <20210917043838.3514789-4-linux@roeck-us.net>
Acked, thx. It'll in next-tree.
On Fri, Sep 17, 2021 at 12:38 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Building csky:allmodconfig results in the following build errors.
>
> arch/csky/mm/tcm.c:9:2: error:
> #error "You should define ITCM_RAM_BASE"
> 9 | #error "You should define ITCM_RAM_BASE"
> | ^~~~~
> arch/csky/mm/tcm.c:14:2: error:
> #error "You should define DTCM_RAM_BASE"
> 14 | #error "You should define DTCM_RAM_BASE"
> | ^~~~~
> arch/csky/mm/tcm.c:18:2: error:
> #error "You should define correct DTCM_RAM_BASE"
> 18 | #error "You should define correct DTCM_RAM_BASE"
>
> This is seen with compile tests since those enable HAVE_TCM,
> but do not provide useful default values for ITCM_RAM_BASE or
> DTCM_RAM_BASE. Disable HAVE_TCM for commpile tests to avoid
> the error.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/csky/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 58ca3ef02bab..823d3d5a9e11 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -241,6 +241,7 @@ endchoice
>
> menuconfig HAVE_TCM
> bool "Tightly-Coupled/Sram Memory"
> + depends on !COMPILE_TEST
> help
> The implementation are not only used by TCM (Tightly-Coupled Meory)
> but also used by sram on SOC bus. It follow existed linux tcm
> --
> 2.33.0
>
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
prev parent reply other threads:[~2021-09-17 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 4:38 [PATCH 0/3] csky fixes Guenter Roeck
2021-09-17 4:38 ` [PATCH 1/3] csky: Select ARCH_WANT_FRAME_POINTERS only if compiler supports it Guenter Roeck
2021-09-17 6:20 ` Guo Ren
2021-09-17 4:38 ` [PATCH 2/3] csky: bitops: Remove duplicate __clear_bit define Guenter Roeck
2021-09-17 4:38 ` [PATCH 3/3] csky: Make HAVE_TCM depend on !COMPILE_TEST Guenter Roeck
2021-09-17 6:19 ` Guo Ren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTSqKZKnUw-UQt5Tiag3T0D04dBW9FijaxPX7Q985=+j7w@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).