From: Stafford Horne <shorne@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>, Guo Ren <guoren@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Sami Tolvanen <samitolvanen@google.com>,
linux-csky@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
nicolas@debian.org
Subject: Re: [PATCH] kbuild: ignore *.cmd files for objects that come from libgcc.a
Date: Mon, 30 May 2022 00:02:54 +0900 [thread overview]
Message-ID: <YpOLHkUZImdEr7yl@antec> (raw)
In-Reply-To: <20220529042318.2630379-1-masahiroy@kernel.org>
Cc Joel, Nicolas
On Sun, May 29, 2022 at 01:23:18PM +0900, Masahiro Yamada wrote:
> Guenter Roeck reported the build breakage for parisc and csky.
> I confirmed nios2 and openrisc are broken as well.
Joel reported and issue building the openrisc kernel as well with this error:
This fails at the link step:
LD vmlinux.o
+ or1k-elf-ld -r -o vmlinux.o --whole-archive
arch/openrisc/kernel/head.o init/built-in.a usr/built-in.a
arch/openrisc/built-in.a kernel/built-in.a certs/built-in.a
mm/built-in.a fs/built-in.a ipc/built-in.a security/built-in.a
crypto/built-in.a block/built-in.a lib/built-in.a drivers/built-in.a
sound/built-in.a net/built-in.a virt/built-in.a --no-whole-archive
--start-group lib/lib.a /usr/lib/gcc/or1k-elf/12/libgcc.a --end-group
or1k-elf-ld: /usr/lib/gcc/or1k-elf/12/libgcc.a: error adding symbols:
archive has no index; run ranlib to add one
Is it the same? It might be good to have details of the error in the commit
message.
> The reason is that they borrow libgcc.a from the toolchains.
>
> For example, see this line in arch/parisc/Makefile:
>
> LIBGCC := $(shell $(CC) -print-libgcc-file-name)
>
> Some objects in libgcc.a are linked to vmlinux.o, but they do not have
> .*.cmd files.
>
> Obviously, there is no EXPORT_SYMBOL in external objects. Ignore them.
>
> (Most of the architectures import library code into the kernel tree.
> Perhaps those 4 architectures can do similar, but I am not sure.)
Ill have a look at this. Could you give an example of what you mean by import
library code, from where? OpenRISC imports builtins from libgcc, also we have
string and other lib routines from within the port.
-Stafford
next prev parent reply other threads:[~2022-05-29 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 4:23 [PATCH] kbuild: ignore *.cmd files for objects that come from libgcc.a Masahiro Yamada
2022-05-29 6:33 ` Guenter Roeck
2022-05-29 15:02 ` Stafford Horne [this message]
2022-05-29 17:21 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpOLHkUZImdEr7yl@antec \
--to=shorne@gmail.com \
--cc=guoren@kernel.org \
--cc=joel@jms.id.au \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=nicolas@debian.org \
--cc=nicolas@fjasle.eu \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox